Add tail-call optimisations + General changes#150
Open
AaravMalani wants to merge 8 commits intomainfrom
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the Python interpreter by implementing Tail-Call Optimization (TCO), adding recursion depth tracking with a corresponding RecursionError, and exposing the __program__ variable. It also updates documentation, refines the standard library's error handling, and extends apply_in_underlying_python to handle non-primitive functions. Feedback includes suggestions to avoid redundant property initialization, replace magic numbers with named constants for recursion limits, and use more robust undefined checks for builtin function results.
Member
|
Great to see this PR. A significant step to a realistic Python implementation for CS1101S. |
…lisation, make undefined returns more explicit for builtins) Co-authored-by: Copilot <copilot@github.com>
…ion appropriately Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__PROGRAM__to__program__to align with Python's naming scheme__program__which stores the code of the program being evaluatedapply_in_underlying_pythonto support non-primitive functionsFixes #144