fix: update multistore to properly recognize directory markers#125
Merged
Conversation
|
🚀 Latest commit deployed to https://source-data-proxy-pr-125.source-coop.workers.dev
|
alukach
changed the title
alukach
pushed a commit
that referenced
this pull request
Apr 9, 2026
🤖 I have created a release *beep* *boop* --- ## [2.1.1](v2.1.0...v2.1.1) (2026-04-02) ### Bug Fixes * update multistore to properly recognize directory markers ([#125](#125)) ([25b1072](25b1072)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: source-release-bot[bot] <265100246+source-release-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I'm changing
Bump
multistoreversion to v0.3.1 to support directory markers (developmentseed/multistore#22).How I did it
Updated multistore to ignore any keys returned by the object store backend that has 0 bytes and ends with
/(these keys are still returned asCommonPrefixes, but notObjects)How to test it
This backend is currently enabled as the backend of https://source-cooperative-git-feat-data-connection-admin-radiantearth.vercel.app. As such, compare the following:
You'll see an empty
staging-gov-datain the before, but no longer in the after.PR Checklist
and I have opened issue/PR #XXX to track the change.
Related Issues
Resolves source-cooperative/source.coop#245