Skip to content

Commit 5e9a2be

Browse files
committed
Revert "fun: never gonna give you up"
This reverts commit 37a7880.
1 parent 4c41234 commit 5e9a2be

5 files changed

Lines changed: 4 additions & 10 deletions

File tree

src/bot/__tests__/requestReview.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ describe('requestReview', () => {
364364
expect(param.ack).toHaveBeenCalled();
365365
});
366366

367-
it.skip('should post a message to the interviewing channel', async () => {
367+
it('should post a message to the interviewing channel', async () => {
368368
const { param } = await callCallback();
369369

370370
expect(param.client.chat.postMessage).toHaveBeenCalledWith({

src/bot/requestReview.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { App } from '@slack/bolt';
77
import { Block, KnownBlock, PlainTextOption, View } from '@slack/types';
88
import { blockUtils } from '@utils/blocks';
99
import log from '@utils/log';
10-
import { bold, codeBlock, compose, italic, link, mention, ul } from '@utils/text';
10+
import { bold, codeBlock, compose, italic, mention, ul } from '@utils/text';
1111
import { PendingReviewer } from '@models/ActiveReview';
1212
import {
1313
ActionId,
@@ -257,7 +257,6 @@ export const requestReview = {
257257
ul(...languages),
258258
bold(`Candidate Type: ${candidateTypeDisplay}`),
259259
bold(`The review is needed by end of day ${deadlineDisplay}`),
260-
link(':warning: Plagiarism Flag Detected', 'https://www.youtube.com/watch?v=dQw4w9WgXcQ'),
261260
candidateIdentifierValue ? italic(`Candidate Identifier: ${candidateIdentifierValue}`) : '',
262261
),
263262
);

src/services/__tests__/ChatService.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ describe('ChatService', () => {
5757
});
5858
});
5959

60-
describe.skip('sendRequestReviewMessage', () => {
60+
describe('sendRequestReviewMessage', () => {
6161
it('should notify the given user that a request is ready for them to review', async () => {
6262
const client = buildMockWebClient();
6363
client.chat.postMessage = jest.fn().mockResolvedValue({

src/utils/RequestBuilder.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { ActionId, BlockId } from '@bot/enums';
2-
import { bold, compose, link, mention, ul } from '@utils/text';
2+
import { bold, compose, mention, ul } from '@utils/text';
33
import { ActionsBlock, Block, SectionBlock } from '@slack/types';
44

55
export const requestBuilder = {
@@ -56,7 +56,6 @@ export const requestBuilder = {
5656
ul(...languages),
5757
bold(`Candidate Type: ${candidateTypeDisplay}`),
5858
bold(`The review is needed by end of day ${deadlineDisplay}`),
59-
link(':warning: Plagiarism Flag Detected', 'https://www.youtube.com/watch?v=dQw4w9WgXcQ'),
6059
),
6160
},
6261
};

src/utils/text.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@ export function li(...items: string[]): string {
2020
return items.map((item, index) => ` ${index + 1}. ${item}`).join('\n');
2121
}
2222

23-
export function link(linkText: string, url: string) {
24-
return `<${url}|${linkText}>`;
25-
}
26-
2723
export function codeBlock(...lines: string[]): string {
2824
return ['```', ...lines, '```'].join('\n');
2925
}

0 commit comments

Comments
 (0)