Fix queue preferences modal title, slot time formatting, timepicker h… (#541)

* Fix queue preferences modal title, slot time formatting, timepicker hours

- Fix modal title 'Interview Queue Preferences' (26 chars) → 'Queue Preferences' to stay under Slack's 25-char limit
- Format slot times as 'Mon, Apr 6, 4 PM–8 PM' instead of raw ISO strings
- Restrict pairing session timepickers to 8 AM–8 PM

* Add tests for formatSlot

Author: kylehoehns

src/bot/acceptPairingSlot.ts

@@ -9,7 +9,7 @@ import { pairingSessionCloser } from '@/services/PairingSessionCloser';
 import { reviewLockManager } from '@utils/reviewLockManager';
 import { lockedExecute } from '@utils/lockedExecute';
 import { reportErrorAndContinue } from '@utils/reportError';
-import { bold, compose, textBlock, ul } from '@utils/text';
+import { bold, compose, formatSlot, textBlock, ul } from '@utils/text';
 import { chatService } from '@/services/ChatService';
 
 export const acceptPairingSlot = {
@@ -69,7 +69,7 @@ export const acceptPairingSlot = {
         );
 
         const selectedSlots = interview.slots.filter(s => selectedSlotIds.includes(s.id));
-        const slotLines = selectedSlots.map(s => `${s.date}, ${s.startTime}–${s.endTime}`);
+        const slotLines = selectedSlots.map(s => formatSlot(s.date, s.startTime, s.endTime));
         await chatService.updateDirectMessage(client, userId, messageTimestamp, [
           textBlock(
             compose(

src/bot/joinQueue.ts

@@ -29,7 +29,7 @@ export const joinQueue = {
 
   dialog(languages: string[]): View {
     return {
-      title: { text: 'Interview Queue Preferences', type: 'plain_text' },
+      title: { text: 'Queue Preferences', type: 'plain_text' },
       type: 'modal',
       callback_id: Interaction.SUBMIT_JOIN_QUEUE,
       blocks: [

src/bot/requestPairingSession.ts

@@ -339,8 +339,10 @@ function buildSlotBlocks(slotNumber: number, state?: SlotState): (Block | KnownB
       element: {
         type: 'timepicker',
         action_id: startId,
+        min_time: '08:00',
+        max_time: '20:00',
         ...(state?.startTime ? { initial_time: state.startTime } : {}),
-      },
+      } as any,
     },
     {
       type: 'input',
@@ -349,8 +351,10 @@ function buildSlotBlocks(slotNumber: number, state?: SlotState): (Block | KnownB
       element: {
         type: 'timepicker',
         action_id: endId,
+        min_time: '08:00',
+        max_time: '20:00',
         ...(state?.endTime ? { initial_time: state.endTime } : {}),
-      },
+      } as any,
     },
   ];
 }

src/services/PairingSessionCloser.ts

@@ -4,7 +4,7 @@ import { pairingSessionsRepo } from '@repos/pairingSessionsRepo';
 import { userRepo } from '@repos/userRepo';
 import { chatService } from '@/services/ChatService';
 import { App } from '@slack/bolt';
-import { mention, ul } from '@utils/text';
+import { formatSlot, mention, ul } from '@utils/text';
 import { reviewLockManager } from '@utils/reviewLockManager';
 import log from '@utils/log';
 
@@ -47,7 +47,7 @@ export const pairingSessionCloser = {
             .map(t => [t.userId, t] as [string, typeof t]),
         ).values(),
       );
-      const slotLines = confirmedSlots.map(s => `${s.date}, ${s.startTime}–${s.endTime}`);
+      const slotLines = confirmedSlots.map(s => formatSlot(s.date, s.startTime, s.endTime));
       await chatService.replyToReviewThread(
         app.client,
         threadId,

src/services/__tests__/PairingSessionCloser.test.ts

@@ -174,7 +174,7 @@ describe('PairingSessionCloser', () => {
       expect(chatService.replyToReviewThread).toHaveBeenCalledWith(
         app.client,
         'thread-1',
-        expect.stringContaining('2026-03-31'),
+        expect.stringContaining('Mar 31'),
       );
       expect(userRepo.markNowAsLastReviewedDate).toHaveBeenCalledWith('u1');
       expect(userRepo.markNowAsLastReviewedDate).toHaveBeenCalledWith('u2');

src/utils/__tests__/text.test.ts

@@ -0,0 +1,23 @@
+import { formatSlot } from '../text';
+
+describe('formatSlot', () => {
+  it('formats a slot with whole-hour times', () => {
+    expect(formatSlot('2026-04-06', '16:00', '20:00')).toBe('Mon, Apr 6, 4 PM–8 PM');
+  });
+
+  it('formats a slot with minute-precision times', () => {
+    expect(formatSlot('2026-04-06', '09:30', '11:00')).toBe('Mon, Apr 6, 9:30 AM–11 AM');
+  });
+
+  it('formats noon and midnight boundaries correctly', () => {
+    expect(formatSlot('2026-04-07', '12:00', '13:00')).toBe('Tue, Apr 7, 12 PM–1 PM');
+  });
+
+  it('formats 8 AM start time correctly', () => {
+    expect(formatSlot('2026-04-10', '08:00', '20:00')).toBe('Fri, Apr 10, 8 AM–8 PM');
+  });
+
+  it('includes the correct day of week', () => {
+    expect(formatSlot('2026-03-31', '13:00', '15:00')).toBe('Tue, Mar 31, 1 PM–3 PM');
+  });
+});

src/utils/text.ts

@@ -49,6 +49,24 @@ export function textBlock(text: string): KnownBlock {
   };
 }
 
+export function formatSlot(date: string, startTime: string, endTime: string): string {
+  const [year, month, day] = date.split('-').map(Number);
+  const dateObj = new Date(year, month - 1, day);
+  const dayOfWeek = dateObj.toLocaleDateString('en-US', { weekday: 'short' });
+  const monthStr = dateObj.toLocaleDateString('en-US', { month: 'short' });
+  return `${dayOfWeek}, ${monthStr} ${day}, ${formatTime(startTime)}–${formatTime(endTime)}`;
+}
+
+function formatTime(hhmm: string): string {
+  const [hourStr, minuteStr] = hhmm.split(':');
+  const hour = Number(hourStr);
+  const minute = Number(minuteStr);
+  const period = hour >= 12 ? 'PM' : 'AM';
+  const hour12 = hour % 12 || 12;
+  const minuteDisplay = minute === 0 ? '' : `:${minuteStr}`;
+  return `${hour12}${minuteDisplay} ${period}`;
+}
+
 export function errorStack(err: Error): string {
   return err.stack ?? '[no stack trace]';
 }