upgrade eslint

Author: brendan-kellam

packages/web/.eslintignore

@@ -0,0 +1,51 @@
+import nextCoreWebVitals from 'eslint-config-next/core-web-vitals';
+import tseslint from 'typescript-eslint';
+import tanstackQuery from '@tanstack/eslint-plugin-query';
+
+const config = [
+    ...nextCoreWebVitals,
+    ...tseslint.configs.recommended,
+    ...tanstackQuery.configs['flat/recommended'],
+    {
+        rules: {
+            // New react-hooks v7 rules disabled as too strict for this codebase's existing patterns.
+            // `set-state-in-effect` flags a very common legitimate pattern (reading external state
+            // into local state on mount / dependency change). `incompatible-library` produces false
+            // positives against @tanstack/react-table and similar libraries.
+            'react-hooks/set-state-in-effect': 'off',
+            'react-hooks/incompatible-library': 'off',
+            // `preserve-manual-memoization` is only relevant when the React Compiler is enabled.
+            'react-hooks/preserve-manual-memoization': 'off',
+            // `immutability` produces false positives for recursive useCallback patterns and
+            // intentional module-level regex lastIndex resets.
+            'react-hooks/immutability': 'off',
+
+            'react-hooks/exhaustive-deps': 'warn',
+            'no-unused-vars': 'off',
+            'no-extra-semi': 'off',
+        },
+    },
+    {
+        files: ['**/*.ts', '**/*.tsx'],
+        rules: {
+            '@typescript-eslint/no-unused-vars': [
+                'warn',
+                {
+                    argsIgnorePattern: '^_',
+                    varsIgnorePattern: '^_',
+                    caughtErrorsIgnorePattern: '^_',
+                },
+            ],
+        },
+    },
+    {
+        // Replaces .eslintignore
+        ignores: [
+            'src/components/**',
+            'next-env.d.ts',
+            'src/proto/**',
+        ],
+    },
+];
+
+export default config;

packages/web/.eslintrc.json

@@ -207,17 +207,18 @@
     "@typescript-eslint/eslint-plugin": "^8.40.0",
     "@typescript-eslint/parser": "^8.40.0",
     "cross-env": "^7.0.3",
-    "eslint": "^8",
+    "eslint": "^9",
     "eslint-config-next": "16.1.6",
     "eslint-plugin-react": "^7.37.5",
-    "eslint-plugin-react-hooks": "^5.2.0",
+    "eslint-plugin-react-hooks": "^7.0.1",
     "jsdom": "^25.0.1",
     "npm-run-all": "^4.1.5",
     "postcss": "^8",
     "react-email": "^5.1.0",
     "tailwindcss": "^3.4.1",
     "tsx": "^4.19.2",
     "typescript": "^5",
+    "typescript-eslint": "^8.56.1",
     "vite-tsconfig-paths": "^5.1.3",
     "vitest": "^2.1.5",
     "vitest-mock-extended": "^3.1.0"

packages/web/eslint.config.mjs

@@ -118,7 +118,6 @@ export default async function Image({ params }: ImageProps) {
                         }}
                     >
                         {/* Avatar */}
-                        {/* eslint-disable-next-line @next/next/no-img-element */}
                         <img
                             src={creatorImage ?? `${env.AUTH_URL}/placeholder_avatar.png`}
                             alt="Avatar"
@@ -165,7 +164,6 @@ export default async function Image({ params }: ImageProps) {
                         >
                             sourcebot.dev
                         </span>
-                        {/* eslint-disable-next-line @next/next/no-img-element */}
                         <img
                             src={`${env.AUTH_URL}/sb_logo_dark_small.png`}
                             alt="Sourcebot"

packages/web/package.json

@@ -33,6 +33,7 @@ export const TrialIndicator = ({ subscription }: Props) => {
             <div className="flex items-center gap-2 px-3 py-1.5 bg-blue-50 dark:bg-blue-900/20 border border-blue-200 dark:border-blue-700 rounded-full text-blue-700 dark:text-blue-400 text-xs font-medium hover:bg-blue-100 dark:hover:bg-blue-900/30 transition-colors cursor-pointer">
                 <span className="inline-block w-2 h-2 bg-blue-400 dark:bg-blue-500 rounded-full"></span>
                 <span>
+                    {/* eslint-disable-next-line react-hooks/purity -- Date.now() during render is intentional for displaying remaining trial days */}
                     {Math.ceil((subscription.nextBillingDate * 1000 - Date.now()) / (1000 * 60 * 60 * 24))} days left in trial
                 </span>
             </div>

packages/web/src/app/[domain]/chat/[id]/opengraph-image.tsx

@@ -29,7 +29,7 @@ export default function Error({ error, reset }: { error: Error & { digest?: stri
                     statusCode: serviceError.statusCode,
                 }
             }
-        /* eslint-disable no-empty */
+         
         } catch {}
 
         return {

packages/web/src/app/[domain]/components/navigationMenu/trialIndicator.tsx

@@ -38,6 +38,7 @@ const AnswerCardComponent = forwardRef<HTMLDivElement, AnswerCardProps>(({
     traceId,
 }, forwardedRef) => {
     const markdownRendererRef = useRef<HTMLDivElement>(null);
+    // eslint-disable-next-line react-hooks/refs -- ref.current is passed to a custom hook, not used directly in render output
     const { tocItems, activeId } = useExtractTOCItems({ target: markdownRendererRef.current });
     const [isTOCButtonToggled, setIsTOCButtonToggled] = useState(false);
     const { toast } = useToast();

packages/web/src/app/error.tsx

@@ -44,7 +44,7 @@ export const createInviteLink = (baseUrl: string, inviteLinkId?: string | null):
  */
 export const createPathWithQueryParams = (path: string, ...queryParams: [string, string | null][]) => {
     // Filter out undefined values
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+     
     queryParams = queryParams.filter(([_key, value]) => value !== null);
 
     if (queryParams.length === 0) {