feat(web): hide security notice in askgithub sign-up modal (#930)

When EXPERIMENT_ASK_GH_ENABLED is true, the sign-up modal should not
display the security notice. This is achieved by adding a hideSecurityNotice
prop to AuthMethodSelector and using it in the askgh LoginModal.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>

Author: msukkari

packages/web/src/app/[domain]/askgh/[owner]/[repo]/components/loginModal.tsx

@@ -37,7 +37,7 @@ export const LoginModal = ({
                         providers={providers}
                         callbackUrl={callbackUrl}
                         context="login"
-                        securityNoticeClosable={true}
+                        hideSecurityNotice={true}
                     />
                 </div>
             </DialogContent>

packages/web/src/app/components/authMethodSelector.tsx

@@ -17,14 +17,16 @@ interface AuthMethodSelectorProps {
     context: "login" | "signup";
     onProviderClick?: (providerId: string) => void;
     securityNoticeClosable?: boolean;
+    hideSecurityNotice?: boolean;
 }
 
 export const AuthMethodSelector = ({
     providers,
     callbackUrl,
     context,
     onProviderClick,
-    securityNoticeClosable = false
+    securityNoticeClosable = false,
+    hideSecurityNotice = false
 }: AuthMethodSelectorProps) => {
     const onSignInWithOauth = useCallback((provider: string) => {
         // Call the optional analytics callback first
@@ -56,7 +58,7 @@ export const AuthMethodSelector = ({
 
     return (
         <>
-            <AuthSecurityNotice closable={securityNoticeClosable} />
+            {!hideSecurityNotice && <AuthSecurityNotice closable={securityNoticeClosable} />}
             <DividerSet
                 elements={[
                     ...(oauthProviders.length > 0 ? [