remove zod parsing altogether

Author: brendan-kellam

packages/web/package.json

@@ -51,7 +51,6 @@
     "@codemirror/search": "^6.5.6",
     "@codemirror/state": "^6.4.1",
     "@codemirror/view": "^6.33.0",
-    "@duplojs/zod-accelerator": "^2.6.2",
     "@floating-ui/react": "^0.27.2",
     "@hookform/resolvers": "^3.9.0",
     "@iconify/react": "^5.1.0",

packages/web/src/features/search/searchApi.ts

@@ -2,19 +2,16 @@
 
 import { sew } from "@/actions";
 import { withOptionalAuthV2 } from "@/withAuthV2";
-import { ZodAccelerator } from "@duplojs/zod-accelerator";
 import { PrismaClient, Repo } from "@sourcebot/db";
 import { base64Decode, createLogger } from "@sourcebot/shared";
 import { StatusCodes } from "http-status-codes";
-import z from "zod";
 import { ErrorCode } from "../../lib/errorCodes";
 import { invalidZoektResponse, ServiceError } from "../../lib/serviceError";
 import { isServiceError, measure } from "../../lib/utils";
 import { SearchRequest, SearchResponse, SourceRange } from "./types";
 import { zoektFetch } from "./zoektClient";
-import { zoektSearchResponseSchema } from "./zoektSchema";
+import { ZoektSearchResponse } from "./zoektSchema";
 
-const acceleratedZoektSearchResponseSchema = ZodAccelerator.build(zoektSearchResponseSchema);
 const logger = createLogger("searchApi");
 
 // List of supported query prefixes in zoekt.
@@ -220,7 +217,7 @@ export const search = async ({ query, matches, contextLines, whole }: SearchRequ
             return invalidZoektResponse(searchResponse);
         }
 
-        const transformZoektSearchResponse = async ({ Result }: z.infer<typeof zoektSearchResponseSchema>) => {
+        const transformZoektSearchResponse = async ({ Result }: ZoektSearchResponse) => {
             // @note (2025-05-12): in zoekt, repositories are identified by the `RepositoryID` field
             // which corresponds to the `id` in the Repo table. In order to efficiently fetch repository
             // metadata when transforming (potentially thousands) of file matches, we aggregate a unique
@@ -394,25 +391,22 @@ export const search = async ({ query, matches, contextLines, whole }: SearchRequ
             false
         );
 
-        const { data: zoektResponse, durationMs: parseZoektResponseDurationMs } = await measure(
-            () => acceleratedZoektSearchResponseSchema.parseAsync(rawZoektResponse),
-            "parse_zoekt_response",
-            false
-        );
+        // @note: We do not use zod parseAsync here since in cases where the
+        // response is large (> 40MB), there can be significant performance issues.
+        const zoektResponse = rawZoektResponse as ZoektSearchResponse;
 
         const { data: response, durationMs: transformZoektResponseDurationMs } = await measure(
             () => transformZoektSearchResponse(zoektResponse),
             "transform_zoekt_response",
             false
         );
 
-        const totalDurationMs = fetchDurationMs + parseJsonDurationMs + parseZoektResponseDurationMs + transformZoektResponseDurationMs;
+        const totalDurationMs = fetchDurationMs + parseJsonDurationMs + transformZoektResponseDurationMs;
 
         // Debug log: timing breakdown
         const timings = [
             { name: "zoekt_fetch", duration: fetchDurationMs },
             { name: "parse_json", duration: parseJsonDurationMs },
-            { name: "parse_zoekt_response", duration: parseZoektResponseDurationMs },
             { name: "transform_zoekt_response", duration: transformZoektResponseDurationMs },
         ];
 
@@ -430,7 +424,6 @@ export const search = async ({ query, matches, contextLines, whole }: SearchRequ
             __debug_timings: {
                 zoekt_fetch: fetchDurationMs,
                 parse_json: parseJsonDurationMs,
-                parse_zoekt_response: parseZoektResponseDurationMs,
                 transform_zoekt_response: transformZoektResponseDurationMs,
             }
         } satisfies SearchResponse;

packages/web/src/features/search/zoektSchema.ts

@@ -75,6 +75,8 @@ export const zoektSearchResponseSchema = z.object({
     }),
 });
 
+export type ZoektSearchResponse = z.infer<typeof zoektSearchResponseSchema>;
+
 // @see : https://github.com/sourcebot-dev/zoekt/blob/3780e68cdb537d5a7ed2c84d9b3784f80c7c5d04/api.go#L728
 const zoektRepoStatsSchema = z.object({
     Repos: z.number(),

yarn.lock

@@ -1630,15 +1630,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@duplojs/zod-accelerator@npm:^2.6.2":
-  version: 2.6.2
-  resolution: "@duplojs/zod-accelerator@npm:2.6.2"
-  peerDependencies:
-    zod: ">=3.0.0 <4.0.0"
-  checksum: 10c0/9b8a1dd6cc7c79df16d6e82b34a3f9f76242f513bb272265adbf159f565785f7c4be14d9cf492053fbacd806d0865b20ce1e9adff28f92f7ff9730121688e2b5
-  languageName: node
-  linkType: hard
-
 "@emnapi/core@npm:^1.3.1":
   version: 1.3.1
   resolution: "@emnapi/core@npm:1.3.1"
@@ -8067,7 +8058,6 @@ __metadata:
     "@codemirror/search": "npm:^6.5.6"
     "@codemirror/state": "npm:^6.4.1"
     "@codemirror/view": "npm:^6.33.0"
-    "@duplojs/zod-accelerator": "npm:^2.6.2"
     "@eslint/eslintrc": "npm:^3"
     "@floating-ui/react": "npm:^0.27.2"
     "@hookform/resolvers": "npm:^3.9.0"