refactor(web): move captureEvent error handling into captureEvent itself

captureEvent now wraps its body in try/catch so callers are guaranteed
it won't throw. Removed all .catch() handlers from call sites in
adapters.ts, server.ts, and apiHandler.ts.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: msukkari

packages/web/src/features/mcp/server.ts

@@ -6,7 +6,7 @@ import { captureEvent } from '@/lib/posthog';
 import { isServiceError } from '@/lib/utils';
 import { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import { ChatVisibility } from '@sourcebot/db';
-import { createLogger, SOURCEBOT_VERSION } from '@sourcebot/shared';
+import { SOURCEBOT_VERSION } from '@sourcebot/shared';
 import _dedent from 'dedent';
 import { z } from 'zod';
 import { getConfiguredLanguageModelsInfo } from "../chat/utils.server";
@@ -24,7 +24,6 @@ import {
 } from '../tools';
 
 const dedent = _dedent.withOptions({ alignValues: true });
-const logger = createLogger('mcp-server');
 
 export async function createMcpServer(options?: { userId?: string }): Promise<McpServer> {
     const server = new McpServer({
@@ -64,9 +63,7 @@ export async function createMcpServer(options?: { userId?: string }): Promise<Mc
                 toolName: 'list_language_models',
                 source: 'sourcebot-mcp-server',
                 success: true,
-            }, { distinctId: options?.userId }).catch((error) => {
-                logger.warn('Failed to capture tool_used event:', error);
-            });
+            }, { distinctId: options?.userId });
             return { content: [{ type: "text", text: JSON.stringify(models) }] };
         }
     );
@@ -115,9 +112,7 @@ export async function createMcpServer(options?: { userId?: string }): Promise<Mc
                         toolName: 'ask_codebase',
                         source: 'sourcebot-mcp-server',
                         success: false,
-                    }, { distinctId: options?.userId }).catch((error) => {
-                        logger.warn('Failed to capture tool_used event:', error);
-                    });
+                    }, { distinctId: options?.userId });
                     return {
                         content: [{ type: "text", text: `Failed to ask codebase: ${result.message}` }],
                     };
@@ -127,9 +122,7 @@ export async function createMcpServer(options?: { userId?: string }): Promise<Mc
                     toolName: 'ask_codebase',
                     source: 'sourcebot-mcp-server',
                     success: true,
-                }, { distinctId: options?.userId }).catch((error) => {
-                    logger.warn('Failed to capture tool_used event:', error);
-                });
+                }, { distinctId: options?.userId });
 
                 const formattedResponse = dedent`
                 ${result.answer}

packages/web/src/features/tools/adapters.ts

@@ -3,7 +3,6 @@ import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
 import { z } from "zod";
 import { captureEvent } from "@/lib/posthog";
 import { ToolContext, ToolDefinition } from "./types";
-import { logger } from "./logger";
 
 export function toVercelAITool<TName extends string, TShape extends z.ZodRawShape, TMetadata>(
     def: ToolDefinition<TName, TShape, TMetadata>,
@@ -25,9 +24,7 @@ export function toVercelAITool<TName extends string, TShape extends z.ZodRawShap
                     toolName: def.name,
                     source: context.source ?? 'unknown',
                     success,
-                }, { distinctId: context.userId }).catch((error) => {
-                    logger.warn(`Failed to capture tool_used event for ${def.name}:`, error);
-                });
+                }, { distinctId: context.userId });
             }
         },
         toModelOutput: ({ output }) => ({
@@ -70,9 +67,7 @@ export function registerMcpTool<TName extends string, TShape extends z.ZodRawSha
                     toolName: def.name,
                     source: context.source ?? 'unknown',
                     success,
-                }, { distinctId: context.userId }).catch((error) => {
-                    logger.warn(`Failed to capture tool_used event for ${def.name}:`, error);
-                });
+                }, { distinctId: context.userId });
             }
         },
     );

packages/web/src/lib/apiHandler.ts

@@ -47,9 +47,7 @@ export function apiHandler<H extends AnyHandler>(
             const source = request.headers.get('X-Sourcebot-Client-Source') ?? 'unknown';
 
             // Fire and forget - don't await to avoid blocking the request
-            captureEvent('api_request', { path, method, source }).catch(() => {
-                // Silently ignore tracking errors
-            });
+            captureEvent('api_request', { path, method, source });
         }
 
         // Call the original handler with all arguments

packages/web/src/lib/posthog.ts

@@ -88,24 +88,28 @@ export const createPostHogClient = async () => {
 }
 
 export async function captureEvent<E extends PosthogEvent>(event: E, properties: PosthogEventMap[E], options?: { distinctId?: string }) {
-    if (env.SOURCEBOT_TELEMETRY_DISABLED === 'true') {
-        return;
-    }
-
-    const distinctId = options?.distinctId ?? await tryGetPostHogDistinctId();
-    const posthog = await createPostHogClient();
+    try {
+        if (env.SOURCEBOT_TELEMETRY_DISABLED === 'true') {
+            return;
+        }
 
-    const headersList = await headers();
-    const host = headersList.get("host") ?? undefined;
-
-    posthog.capture({
-        event,
-        properties: {
-            ...properties,
-            sourcebot_version: SOURCEBOT_VERSION,
-            install_id: env.SOURCEBOT_INSTALL_ID,
-            $host: host,
-        },
-        distinctId,
-    });
+        const distinctId = options?.distinctId ?? await tryGetPostHogDistinctId();
+        const posthog = await createPostHogClient();
+
+        const headersList = await headers();
+        const host = headersList.get("host") ?? undefined;
+
+        posthog.capture({
+            event,
+            properties: {
+                ...properties,
+                sourcebot_version: SOURCEBOT_VERSION,
+                install_id: env.SOURCEBOT_INSTALL_ID,
+                $host: host,
+            },
+            distinctId,
+        });
+    } catch {
+        // Telemetry should never break application functionality.
+    }
 }