feedback

Author: brendan-kellam

packages/web/src/app/(app)/@sidebar/components/defaultSidebar/chatHistory.tsx

@@ -119,7 +119,7 @@ export function ChatHistory({ chatHistory, hasMore }: ChatHistoryProps) {
                                         setIsDeleteDialogOpen(true);
                                     }}
                                 >
-                                    <SidebarMenuAction className="opacity-0 group-hover/chat:opacity-100 transition-opacity">
+                                    <SidebarMenuAction showOnHover className="transition-opacity">
                                         <EllipsisIcon className="w-4 h-4" />
                                     </SidebarMenuAction>
                                 </ChatActionsDropdown>

packages/web/src/app/(app)/search/components/searchResultsPage.tsx

@@ -15,11 +15,13 @@ import { RepositoryInfo, SearchResultFile, SearchStats } from "@/features/search
 import useCaptureEvent from "@/hooks/useCaptureEvent";
 import { useNonEmptyQueryParam } from "@/hooks/useNonEmptyQueryParam";
 import { useSearchHistory } from "@/hooks/useSearchHistory";
+import { ServiceErrorException } from "@/lib/serviceError";
 import { SearchQueryParams } from "@/lib/types";
-import { cn, createPathWithQueryParams } from "@/lib/utils";
+import { createPathWithQueryParams } from "@/lib/utils";
 import { InfoCircledIcon } from "@radix-ui/react-icons";
 import { useLocalStorage } from "@uidotdev/usehooks";
-import { AlertTriangleIcon, BugIcon, FilterIcon, LogIn, RefreshCwIcon } from "lucide-react";
+import { AlertTriangleIcon, BugIcon, FilterIcon, RefreshCwIcon } from "lucide-react";
+import { Session } from "next-auth";
 import { useRouter } from "next/navigation";
 import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 import { useHotkeys } from "react-hotkeys-hook";
@@ -31,15 +33,12 @@ import { CodePreviewPanel } from "./codePreviewPanel";
 import { FilterPanel } from "./filterPanel";
 import { useFilteredMatches } from "./filterPanel/useFilterMatches";
 import { SearchResultsPanel, SearchResultsPanelHandle } from "./searchResultsPanel";
-import { ServiceErrorException } from "@/lib/serviceError";
-import { Session } from "next-auth";
 
 interface SearchResultsPageProps {
     searchQuery: string;
     defaultMaxMatchCount: number;
     isRegexEnabled: boolean;
     isCaseSensitivityEnabled: boolean;
-    session: Session | null;
     isSearchAssistSupported: boolean;
 }
 
@@ -48,7 +47,6 @@ export const SearchResultsPage = ({
     defaultMaxMatchCount,
     isRegexEnabled,
     isCaseSensitivityEnabled,
-    session,
     isSearchAssistSupported,
 }: SearchResultsPageProps) => {
     const router = useRouter();

packages/web/src/app/(app)/search/page.tsx

@@ -1,7 +1,6 @@
 import { env } from "@sourcebot/shared";
 import { SearchLandingPage } from "./components/searchLandingPage";
 import { SearchResultsPage } from "./components/searchResultsPage";
-import { auth } from "@/auth";
 import { getConfiguredLanguageModelsInfo } from "@/features/chat/utils.server";
 
 interface SearchPageProps {
@@ -18,7 +17,6 @@ export default async function SearchPage(props: SearchPageProps) {
     const isRegexEnabled = searchParams?.isRegexEnabled === "true";
     const isCaseSensitivityEnabled = searchParams?.isCaseSensitivityEnabled === "true";
 
-    const session = await auth();
     const languageModels = await getConfiguredLanguageModelsInfo();
     const isSearchAssistSupported = languageModels.length > 0;
 
@@ -32,7 +30,6 @@ export default async function SearchPage(props: SearchPageProps) {
             defaultMaxMatchCount={env.DEFAULT_MAX_MATCH_COUNT}
             isRegexEnabled={isRegexEnabled}
             isCaseSensitivityEnabled={isCaseSensitivityEnabled}
-            session={session}
             isSearchAssistSupported={isSearchAssistSupported}
         />
     )

packages/web/src/app/(app)/settings/apiKeys/apiKeysPage.tsx

@@ -112,18 +112,17 @@ export function ApiKeysPage({ canCreateApiKey, apiKeys }: ApiKeysPageProps) {
     };
 
     const handleDeleteApiKey = async (name: string) => {
-        try {
-            await deleteApiKey(name);
-            router.refresh();
-            toast({ description: "API key deleted" });
-        } catch (error) {
-            console.error("Failed to delete API key", error);
+        const result = await deleteApiKey(name);
+        if (isServiceError(result)) {
             toast({
                 title: "Error",
-                description: `Failed to delete API key: ${error}`,
+                description: `Failed to delete API key: ${result.message}`,
                 variant: "destructive",
             });
+            return;
         }
+        router.refresh();
+        toast({ description: "API key deleted" });
     };
 
     const sortedKeys = useMemo(
@@ -272,7 +271,7 @@ export function ApiKeysPage({ canCreateApiKey, apiKeys }: ApiKeysPageProps) {
                                         <Button
                                             variant="ghost"
                                             size="icon"
-                                            className="opacity-0 group-hover:opacity-100 transition-opacity text-muted-foreground hover:text-destructive flex-shrink-0"
+                                            className="opacity-0 group-hover:opacity-100 group-focus-within:opacity-100 focus-visible:opacity-100 transition-opacity text-muted-foreground hover:text-destructive flex-shrink-0"
                                         >
                                             <Trash2 className="h-4 w-4" />
                                         </Button>

packages/web/src/app/api/(server)/chats/route.ts

@@ -34,9 +34,10 @@ export const GET = apiHandler(async (request: NextRequest) => {
                     },
                 } : {}),
             },
-            orderBy: {
-                [sortBy]: sortOrder,
-            },
+            orderBy: [
+                { [sortBy]: sortOrder },
+                { id: "asc" },
+            ],
             take: limit + 1,
             ...(cursor ? {
                 cursor: { id: cursor },

packages/web/src/app/api/(server)/chats/types.ts

@@ -2,7 +2,7 @@ import { z } from "zod";
 
 export const listChatsQueryParamsSchema = z.object({
     cursor: z.string().optional(),
-    limit: z.coerce.number().int().positive().default(20),
+    limit: z.coerce.number().int().positive().max(100).default(20),
     query: z.string().optional(),
     sortBy: z.enum(["name", "updatedAt"]).default("updatedAt"),
     sortOrder: z.enum(["asc", "desc"]).default("desc"),