refactor: share REVIEW_AGENT_LOG_DIR constant between app.ts and invokeDiffReviewLlm.ts

Export the log directory constant from invokeDiffReviewLlm.ts and
import it in app.ts to ensure a single source of truth for the
review agent log directory path.

Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>

Author: cursoragent

packages/web/src/features/agents/review-agent/app.ts

@@ -2,6 +2,7 @@ import { Octokit } from "octokit";
 import { generatePrReviews } from "@/features/agents/review-agent/nodes/generatePrReview";
 import { githubPushPrReviews } from "@/features/agents/review-agent/nodes/githubPushPrReviews";
 import { githubPrParser } from "@/features/agents/review-agent/nodes/githubPrParser";
+import { REVIEW_AGENT_LOG_DIR } from "@/features/agents/review-agent/nodes/invokeDiffReviewLlm";
 import { env } from "@sourcebot/shared";
 import { GitHubPullRequest } from "@/features/agents/review-agent/types";
 import path from "path";
@@ -30,9 +31,8 @@ export async function processGitHubPullRequest(octokit: Octokit, pullRequest: Gi
 
     let reviewAgentLogPath: string | undefined;
     if (env.REVIEW_AGENT_LOGGING_ENABLED) {
-        const reviewAgentLogDir = path.join(env.DATA_CACHE_DIR, "review-agent");
-        if (!fs.existsSync(reviewAgentLogDir)) {
-            fs.mkdirSync(reviewAgentLogDir, { recursive: true });
+        if (!fs.existsSync(REVIEW_AGENT_LOG_DIR)) {
+            fs.mkdirSync(REVIEW_AGENT_LOG_DIR, { recursive: true });
         }
 
         const timestamp = new Date().toLocaleString('en-US', {
@@ -44,7 +44,7 @@ export async function processGitHubPullRequest(octokit: Octokit, pullRequest: Gi
             second: '2-digit',
             hour12: false
         }).replace(/(\d+)\/(\d+)\/(\d+), (\d+):(\d+):(\d+)/, '$3_$1_$2_$4_$5_$6');
-        reviewAgentLogPath = path.join(reviewAgentLogDir, `review-agent-${pullRequest.number}-${timestamp}.log`);
+        reviewAgentLogPath = path.join(REVIEW_AGENT_LOG_DIR, `review-agent-${pullRequest.number}-${timestamp}.log`);
         logger.info(`Review agent logging to ${reviewAgentLogPath}`);
     }
 

packages/web/src/features/agents/review-agent/nodes/invokeDiffReviewLlm.ts

@@ -7,11 +7,11 @@ import { createLogger } from "@sourcebot/shared";
 
 const logger = createLogger('invoke-diff-review-llm');
 
-const REVIEW_AGENT_LOG_BASE = path.join(env.DATA_CACHE_DIR, 'review-agent');
+export const REVIEW_AGENT_LOG_DIR = path.join(env.DATA_CACHE_DIR, 'review-agent');
 
 const validateLogPath = (logPath: string): void => {
     const resolved = path.resolve(logPath);
-    if (!resolved.startsWith(REVIEW_AGENT_LOG_BASE + path.sep)) {
+    if (!resolved.startsWith(REVIEW_AGENT_LOG_DIR + path.sep)) {
         throw new Error('reviewAgentLogPath escapes log directory');
     }
 };