Skip to content

Commit beff3b7

Browse files
committed
actually resolve file path properly to address codeql alert
1 parent 284d89c commit beff3b7

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

  • packages/web/src/features/agents/review-agent

packages/web/src/features/agents/review-agent/lib.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,9 @@ import fs from "fs";
55
export const REVIEW_AGENT_LOG_DIR = env.DATA_CACHE_DIR + "/review-agent";
66

77
export const appendReviewAgentLog = (logFileName: string, log: string): void => {
8-
fs.appendFileSync(path.join(REVIEW_AGENT_LOG_DIR, logFileName), log);
8+
const resolvedPath = path.resolve(REVIEW_AGENT_LOG_DIR, logFileName);
9+
if (!resolvedPath.startsWith(path.resolve(REVIEW_AGENT_LOG_DIR) + path.sep)) {
10+
throw new Error(`Invalid log file path: ${logFileName}`);
11+
}
12+
fs.appendFileSync(resolvedPath, log);
913
};

0 commit comments

Comments
 (0)