remove search scope selector constraint

Author: brendan-kellam

packages/web/src/app/[domain]/askgh/[owner]/[repo]/components/landingPage.tsx

@@ -77,7 +77,6 @@ export const LandingPage = ({
                             languageModels={languageModels}
                             selectedSearchScopes={selectedSearchScopes}
                             searchContexts={[]}
-                            onContextSelectorOpenChanged={setIsContextSelectorOpen}
                             isDisabled={isChatBoxDisabled}
                         />
                         <Separator />

packages/web/src/app/[domain]/chat/components/landingPageChatBox.tsx

@@ -42,7 +42,6 @@ export const LandingPageChatBox = ({
                     languageModels={languageModels}
                     selectedSearchScopes={selectedSearchScopes}
                     searchContexts={searchContexts}
-                    onContextSelectorOpenChanged={setIsContextSelectorOpen}
                     isDisabled={isChatBoxDisabled}
                 />
                 <Separator />

packages/web/src/features/chat/agent.ts

@@ -15,14 +15,9 @@ import {
 import { randomUUID } from "crypto";
 import _dedent from "dedent";
 import { ANSWER_TAG, FILE_REFERENCE_PREFIX } from "./constants";
-import { findSymbolReferencesDefinition } from "@/features/tools/findSymbolReferences";
-import { findSymbolDefinitionsDefinition } from "@/features/tools/findSymbolDefinitions";
-import { readFileDefinition } from "@/features/tools/readFile";
-import { grepDefinition } from "@/features/tools/grep";
 import { Source } from "./types";
 import { addLineNumbers, fileReferenceToString } from "./utils";
 import { createTools } from "./tools";
-import { globDefinition, listTreeDefinition } from "../tools";
 
 const dedent = _dedent.withOptions({ alignValues: true });
 

packages/web/src/features/chat/components/chatBox/chatBox.tsx

@@ -7,7 +7,7 @@ import { CustomEditor, LanguageModelInfo, MentionElement, RenderElementPropsFor,
 import { insertMention, slateContentToString } from "@/features/chat/utils";
 import { cn, IS_MAC } from "@/lib/utils";
 import { computePosition, flip, offset, shift, VirtualElement } from "@floating-ui/react";
-import { ArrowUp, Loader2, StopCircleIcon, TriangleAlertIcon } from "lucide-react";
+import { ArrowUp, Loader2, StopCircleIcon } from "lucide-react";
 import { Fragment, KeyboardEvent, memo, useCallback, useEffect, useMemo, useRef, useState } from "react";
 import { useHotkeys } from "react-hotkeys-hook";
 import { Descendant, insertText } from "slate";
@@ -32,7 +32,6 @@ interface ChatBoxProps {
     languageModels: LanguageModelInfo[];
     selectedSearchScopes: SearchScope[];
     searchContexts: SearchContextQuery[];
-    onContextSelectorOpenChanged: (isOpen: boolean) => void;
 }
 
 const ChatBoxComponent = ({
@@ -46,7 +45,6 @@ const ChatBoxComponent = ({
     languageModels,
     selectedSearchScopes,
     searchContexts,
-    onContextSelectorOpenChanged,
 }: ChatBoxProps) => {
     const suggestionsBoxRef = useRef<HTMLDivElement>(null);
     const [index, setIndex] = useState(0);
@@ -106,7 +104,7 @@ const ChatBoxComponent = ({
 
     const { isSubmitDisabled, isSubmitDisabledReason } = useMemo((): {
         isSubmitDisabled: true,
-        isSubmitDisabledReason: "empty" | "redirecting" | "generating" | "no-repos-selected" | "no-language-model-selected"
+        isSubmitDisabledReason: "empty" | "redirecting" | "generating" | "no-language-model-selected"
     } | {
         isSubmitDisabled: false,
         isSubmitDisabledReason: undefined,
@@ -132,13 +130,6 @@ const ChatBoxComponent = ({
             }
         }
 
-        if (selectedSearchScopes.length === 0) {
-            return {
-                isSubmitDisabled: true,
-                isSubmitDisabledReason: "no-repos-selected",
-            }
-        }
-
         if (selectedLanguageModel === undefined) {
 
             return {
@@ -152,24 +143,10 @@ const ChatBoxComponent = ({
             isSubmitDisabledReason: undefined,
         }
 
-    }, [
-        editor.children,
-        isRedirecting,
-        isGenerating,
-        selectedSearchScopes.length,
-        selectedLanguageModel,
-    ])
+    }, [editor.children, isRedirecting, isGenerating, selectedLanguageModel])
 
     const onSubmit = useCallback(() => {
         if (isSubmitDisabled) {
-            if (isSubmitDisabledReason === "no-repos-selected") {
-                toast({
-                    description: "⚠️ You must select at least one search scope",
-                    variant: "destructive",
-                });
-                onContextSelectorOpenChanged(true);
-            }
-
             if (isSubmitDisabledReason === "no-language-model-selected") {
                 toast({
                     description: "⚠️ You must select a language model",
@@ -181,7 +158,7 @@ const ChatBoxComponent = ({
         }
 
         _onSubmit(editor.children, editor);
-    }, [_onSubmit, editor, isSubmitDisabled, isSubmitDisabledReason, toast, onContextSelectorOpenChanged]);
+    }, [_onSubmit, editor, isSubmitDisabled, isSubmitDisabledReason, toast]);
 
     const onInsertSuggestion = useCallback((suggestion: Suggestion) => {
         switch (suggestion.type) {
@@ -351,14 +328,6 @@ const ChatBoxComponent = ({
                                     </Button>
                                 </div>
                             </TooltipTrigger>
-                            {(isSubmitDisabled && isSubmitDisabledReason === "no-repos-selected") && (
-                                <TooltipContent>
-                                    <div className="flex flex-row items-center">
-                                        <TriangleAlertIcon className="h-4 w-4 text-warning mr-1" />
-                                        <span className="text-destructive">You must select at least one search scope</span>
-                                    </div>
-                                </TooltipContent>
-                            )}
                         </Tooltip>
                     )}
             </div>

packages/web/src/features/chat/components/chatBox/searchScopeSelector.tsx

@@ -103,15 +103,6 @@ export const SearchScopeSelector = forwardRef<
             })
         }, [onSelectedSearchScopesChange]);
 
-        const handleSelectAll = useCallback(() => {
-            onSelectedSearchScopesChange(allSearchScopeItems);
-            requestAnimationFrame(() => {
-                if (scrollContainerRef.current) {
-                    scrollContainerRef.current.scrollTop = 0;
-                }
-            });
-        }, [onSelectedSearchScopesChange, allSearchScopeItems]);
-
         const handleTogglePopover = useCallback(() => {
             onOpenChanged(!isOpen);
         }, [onOpenChanged, isOpen]);
@@ -241,7 +232,7 @@ export const SearchScopeSelector = forwardRef<
                                         className={cn("text-sm text-muted-foreground mx-1 font-medium")}
                                     >
                                         {
-                                            selectedSearchScopes.length === 0 ? `Search scopes` :
+                                            selectedSearchScopes.length === 0 ? `All repos` :
                                                 selectedSearchScopes.length === 1 ? selectedSearchScopes[0].name :
                                                     `${selectedSearchScopes.length} selected`
                                         }
@@ -279,14 +270,6 @@ export const SearchScopeSelector = forwardRef<
                                     </div>
                                 ) : (
                                     <div className="p-1">
-                                        {!searchQuery && (
-                                            <div
-                                                onClick={handleSelectAll}
-                                                className="flex items-center px-2 py-1.5 text-sm text-muted-foreground hover:text-foreground cursor-pointer transition-colors rounded-sm hover:bg-accent"
-                                            >
-                                                <span className="text-xs">Select all</span>
-                                            </div>
-                                        )}
                                         <div
                                             style={{
                                                 height: `${virtualizer.getTotalSize()}px`,

packages/web/src/features/chat/components/chatThread/chatThread.tsx

@@ -462,7 +462,6 @@ export const ChatThread = ({
                                     languageModels={languageModels}
                                     selectedSearchScopes={selectedSearchScopes}
                                     searchContexts={searchContexts}
-                                    onContextSelectorOpenChanged={setIsContextSelectorOpen}
                                     isDisabled={languageModels.length === 0}
                                 />
                                 <div className="w-full flex flex-row items-center bg-accent rounded-b-md px-2">