Skip to content

chore(ask_sb): Allow for multiple user feedback #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendan-kellam merged 3 commits into from
Jul 25, 2025
Merged

chore(ask_sb): Allow for multiple user feedback #395

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c8b29e
fix
brendan-kellam Jul 25, 2025
b039c53
Merge branch 'main' into bkellam/chat_multi_feedback
brendan-kellam Jul 25, 2025
beb502c
nit: rearange changelog
brendan-kellam Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions packages/web/src/features/chat/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,14 +212,14 @@ export const deleteChat = async ({ chatId }: { chatId: string }, domain: string)
)
);

export const submitFeedback = async ({
chatId,
messageId,
feedbackType
}: {
chatId: string,
messageId: string,
feedbackType: 'like' | 'dislike'
export const submitFeedback = async ({
chatId,
messageId,
feedbackType
}: {
chatId: string,
messageId: string,
feedbackType: 'like' | 'dislike'
}, domain: string) => sew(() =>
withAuth((userId) =>
withOrgMembership(userId, domain, async ({ org }) => {
Expand All @@ -246,13 +246,16 @@ export const submitFeedback = async ({
...message,
metadata: {
...message.metadata,
feedback: {
type: feedbackType,
timestamp: new Date().toISOString(),
userId: userId,
}
feedback: [
...(message.metadata?.feedback ?? []),
{
type: feedbackType,
timestamp: new Date().toISOString(),
userId: userId,
}
]
}
};
} satisfies SBChatMessage;
}
return message;
});
Expand Down
4 changes: 1 addition & 3 deletions packages/web/src/features/chat/components/chatThread/answerCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ interface AnswerCardProps {
answerText: string;
messageId: string;
chatId: string;
feedback?: 'like' | 'dislike' | undefined;
traceId?: string;
}

Expand All @@ -36,7 +35,6 @@ export const AnswerCard = forwardRef<HTMLDivElement, AnswerCardProps>(({
answerText,
messageId,
chatId,
feedback: _feedback,
traceId,
}, forwardedRef) => {
const markdownRendererRef = useRef<HTMLDivElement>(null);
Expand All @@ -45,7 +43,7 @@ export const AnswerCard = forwardRef<HTMLDivElement, AnswerCardProps>(({
const { toast } = useToast();
const domain = useDomain();
const [isSubmittingFeedback, setIsSubmittingFeedback] = useState(false);
const [feedback, setFeedback] = useState<'like' | 'dislike' | undefined>(_feedback);
const [feedback, setFeedback] = useState<'like' | 'dislike' | undefined>(undefined);
Comment thread
brendan-kellam marked this conversation as resolved.
const captureEvent = useCaptureEvent();

useImperativeHandle(
Expand Down
1 change: 0 additions & 1 deletion packages/web/src/features/chat/components/chatThread/chatThreadListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,6 @@ export const ChatThreadListItem = forwardRef<HTMLDivElement, ChatThreadListItemP
answerText={answerPart.text.replace(ANSWER_TAG, '').trim()}
chatId={chatId}
messageId={assistantMessage.id}
feedback={messageMetadata?.feedback?.type}
traceId={messageMetadata?.traceId}
/>
) : !isStreaming && (
Expand Down
4 changes: 2 additions & 2 deletions packages/web/src/features/chat/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ export const sbChatMessageMetadataSchema = z.object({
totalOutputTokens: z.number().optional(),
totalTokens: z.number().optional(),
totalResponseTimeMs: z.number().optional(),
feedback: z.object({
feedback: z.array(z.object({
type: z.enum(['like', 'dislike']),
timestamp: z.string(), // ISO date string
userId: z.string(),
}).optional(),
})).optional(),
selectedRepos: z.array(z.string()).optional(),
traceId: z.string().optional(),
});
Expand Down