Skip to content

[search bar] multi-line wrap#501

Merged
brendan-kellam merged 4 commits intosourcebot-dev:mainfrom
drew-u410:drew/search_bar_wrap_it
Sep 16, 2025
Merged

[search bar] multi-line wrap#501
brendan-kellam merged 4 commits intosourcebot-dev:mainfrom
drew-u410:drew/search_bar_wrap_it

Conversation

@drew-u410
Copy link
Copy Markdown
Contributor

  • Exceeding the search bar length on the homepage results in a scrollbar vs. multi-line wrap.
  • Exceeding the search bar length on query pages hides the text vs. a multi-line wrap.
  • Fixes both cases.
Current Page Fixed Page
current_home fixed_home
current_query fixed_query

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 9, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brendan-kellam
Copy link
Copy Markdown
Contributor

To double check, what does it look like when the suggestions dropdown is expanded when the number of lines is > 1 ?
image

@brendan-kellam brendan-kellam self-requested a review September 11, 2025 21:36
brendan-kellam
brendan-kellam previously approved these changes Sep 11, 2025
Copy link
Copy Markdown
Contributor

@brendan-kellam brendan-kellam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this is a good change thanks 👍

@drew-u410
Copy link
Copy Markdown
Contributor Author

Screenshot 2025-09-12 at 6 55 33 AM

@drew-u410 drew-u410 force-pushed the drew/search_bar_wrap_it branch 2 times, most recently from c50a7ac to 69e7dbd Compare September 12, 2025 11:01
@drew-u410
Copy link
Copy Markdown
Contributor Author

To double check, what does it look like when the suggestions dropdown is expanded when the number of lines is > 1 ? image

Replied below w/image + rebased!

@brendan-kellam
Copy link
Copy Markdown
Contributor

Screenshot 2025-09-12 at 6 55 33 AM

hmm ok, it looks like the suggestion dropdown isn't being displaced downards like I would expect - might cause issues if the box goes >3 lines. I'm ok with merging this in now though and we can fix this nit after

@brendan-kellam brendan-kellam merged commit 660623a into sourcebot-dev:main Sep 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants