fix(web): Fix carousel perf issue + improvements to withAuth middleware#507
Merged
brendan-kellam merged 8 commits intomainfrom Sep 16, 2025
Merged
fix(web): Fix carousel perf issue + improvements to withAuth middleware#507brendan-kellam merged 8 commits intomainfrom
brendan-kellam merged 8 commits intomainfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
2e0fd0d to
b4b6e4e
Compare
msukkari
previously approved these changes
Sep 16, 2025
packages/web/src/app/[domain]/components/homepage/repositorySnapshot.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is two unrelated things:
withAuthV2andwithOptionalAuthV2. Some thoughts:withAuthandwithOrgMembership.allowAnonymousAccessneeds to be explicitly set when the minimum role isGUEST, the api key hash was passed as a param instead of extracting it from the header, etc.)withAuthV2andwithOptionalAuthV2streamlines things in the following ways:withMinimumOrgRolecan be used), or 2) APIs that require authentication but not membership (e.g., invite redemption).Currently the
getReposaction is using this, but planning on refactoring all actions in a followup PR.