feat(chore): fix sonar issue

fix sonar issue

GH-27

Author: Sourav-kashyap

src/providers/sdk/chargebee/adapter/payment-intent.adapter.ts

@@ -6,16 +6,23 @@ import {
   ChargebeeCardDefaults,
 } from '../type';
 
+/** Default fallback values for card details when config is not provided */
+const DEFAULT_EXPIRY_MONTH = 12;
+const DEFAULT_FUNDING_TYPE = 'credit';
+const DEFAULT_CARD_BRAND = 'unknown';
+
 export class ChargebeePaymentIntentAdapter {
   private readonly cardDefaults: Required<ChargebeeCardDefaults>;
 
   constructor(cardDefaults?: ChargebeeCardDefaults) {
     const currentYear = new Date().getFullYear();
     this.cardDefaults = {
-      defaultExpiryMonth: cardDefaults?.defaultExpiryMonth ?? 12,
+      defaultExpiryMonth:
+        cardDefaults?.defaultExpiryMonth ?? DEFAULT_EXPIRY_MONTH,
       defaultExpiryYear: cardDefaults?.defaultExpiryYear ?? currentYear,
-      defaultFundingType: cardDefaults?.defaultFundingType ?? 'credit',
-      defaultCardBrand: cardDefaults?.defaultCardBrand ?? 'unknown',
+      defaultFundingType:
+        cardDefaults?.defaultFundingType ?? DEFAULT_FUNDING_TYPE,
+      defaultCardBrand: cardDefaults?.defaultCardBrand ?? DEFAULT_CARD_BRAND,
     };
   }
 

src/providers/sdk/stripe/adapter/payment-source.adapter.ts

@@ -7,16 +7,23 @@ import {
   StripeCardDefaults,
 } from '../type';
 
+/** Default fallback values for card details when config is not provided */
+const DEFAULT_EXPIRY_MONTH = 12;
+const DEFAULT_FUNDING_TYPE = 'credit';
+const DEFAULT_CARD_BRAND = 'unknown';
+
 export class StripePaymentAdapter implements IAdapter<IStripePaymentSource> {
   private readonly cardDefaults: Required<StripeCardDefaults>;
 
   constructor(cardDefaults?: StripeCardDefaults) {
     const currentYear = new Date().getFullYear();
     this.cardDefaults = {
-      defaultExpiryMonth: cardDefaults?.defaultExpiryMonth ?? 12,
+      defaultExpiryMonth:
+        cardDefaults?.defaultExpiryMonth ?? DEFAULT_EXPIRY_MONTH,
       defaultExpiryYear: cardDefaults?.defaultExpiryYear ?? currentYear,
-      defaultFundingType: cardDefaults?.defaultFundingType ?? 'credit',
-      defaultCardBrand: cardDefaults?.defaultCardBrand ?? 'unknown',
+      defaultFundingType:
+        cardDefaults?.defaultFundingType ?? DEFAULT_FUNDING_TYPE,
+      defaultCardBrand: cardDefaults?.defaultCardBrand ?? DEFAULT_CARD_BRAND,
     };
   }