fix(provider): narrow the type for defaultPricingModel and throws descriptive error if itemId is missing

narrow the type for defaultPricingModel and throws descriptive error if  itemId is missing

Author: Piyush Singh Gaur

src/__tests__/unit/chargebee-subscription.service.unit.ts

@@ -166,7 +166,7 @@ describe('ChargeBeeService - Subscription Management', () => {
       expect(result.product).to.equal('enterprise-plan');
       expect(result.recurring?.interval).to.equal(RecurringInterval.MONTH);
       expect(result.recurring?.intervalCount).to.equal(1);
-      expect(result.active).to.be.true();
+      expect(result.active).to.be.true;
     });
 
     it('returns undefined recurring when no period_unit is set', async () => {
@@ -190,7 +190,7 @@ describe('ChargeBeeService - Subscription Management', () => {
         product: 'setup',
       });
 
-      expect(result.recurring).to.be.undefined();
+      expect(result.recurring).to.be.undefined;
     });
   });
 
@@ -258,7 +258,7 @@ describe('ChargeBeeService - Subscription Management', () => {
       expect(result.customerId).to.equal('cust_tenant_abc');
       expect(result.currentPeriodStart).to.equal(1700000000);
       expect(result.currentPeriodEnd).to.equal(1702592000);
-      expect(result.cancelAtPeriodEnd).to.be.false();
+      expect(result.cancelAtPeriodEnd).to.be.false;
     });
   });
 
@@ -301,7 +301,7 @@ describe('ChargeBeeService - Subscription Management', () => {
 
       const [, params] = updateStub.firstCall.args;
       // ProrationBehavior.NONE -> prorate: false
-      expect(params!.prorate).to.be.false();
+      expect(params!.prorate).to.be.false;
     });
   });
 
@@ -325,7 +325,7 @@ describe('ChargeBeeService - Subscription Management', () => {
         Record<string, unknown>,
       ];
       expect(subId).to.equal('sub_cb_001');
-      expect(params.end_of_term).to.be.false();
+      expect(params.end_of_term).to.be.false;
       expect(params.cancel_reason_code).to.equal('customer_request');
     });
 
@@ -348,7 +348,7 @@ describe('ChargeBeeService - Subscription Management', () => {
         string,
         Record<string, unknown>,
       ];
-      expect(params.end_of_term).to.be.true();
+      expect(params.end_of_term).to.be.true;
       expect(params.cancel_reason_code).to.equal('not_paid');
     });
   });
@@ -453,7 +453,7 @@ describe('ChargeBeeService - Subscription Management', () => {
 
       const result = await service.checkProductExists('enterprise-plan');
 
-      expect(result).to.be.true();
+      expect(result).to.be.true;
     });
 
     it('returns false when the item is archived', async () => {
@@ -463,7 +463,7 @@ describe('ChargeBeeService - Subscription Management', () => {
 
       const result = await service.checkProductExists('old-plan');
 
-      expect(result).to.be.false();
+      expect(result).to.be.false;
     });
 
     it('returns false when Chargebee signals resource_not_found', async () => {
@@ -478,7 +478,7 @@ describe('ChargeBeeService - Subscription Management', () => {
 
       const result = await service.checkProductExists('missing-plan');
 
-      expect(result).to.be.false();
+      expect(result).to.be.false;
     });
 
     it('re-throws unexpected errors from Chargebee', async () => {

src/__tests__/unit/stripe-subscription.service.unit.ts

@@ -185,7 +185,7 @@ describe('StripeService - Subscription Management', () => {
       expect(result.product).to.equal('prod_enterprise_123');
       expect(result.recurring?.interval).to.equal(RecurringInterval.MONTH);
       expect(result.recurring?.intervalCount).to.equal(1);
-      expect(result.active).to.be.true();
+      expect(result.active).to.be.true;
     });
 
     it('handles a one-time price (no recurring field)', async () => {
@@ -209,7 +209,7 @@ describe('StripeService - Subscription Management', () => {
 
       const result = await service.createPrice(priceInput);
 
-      expect(result.recurring).to.be.undefined();
+      expect(result.recurring).to.be.undefined;
     });
   });
 
@@ -347,7 +347,7 @@ describe('StripeService - Subscription Management', () => {
       expect(result.customerId).to.equal('cus_tenant_abc');
       expect(result.currentPeriodStart).to.equal(1700000000);
       expect(result.currentPeriodEnd).to.equal(1702592000);
-      expect(result.cancelAtPeriodEnd).to.be.false();
+      expect(result.cancelAtPeriodEnd).to.be.false;
     });
   });
 
@@ -643,15 +643,15 @@ describe('StripeService - Subscription Management', () => {
 
       const result = await service.checkProductExists('prod_active_001');
 
-      expect(result).to.be.true();
+      expect(result).to.be.true;
     });
 
     it('returns false when the product is archived (active: false)', async () => {
       stripeStub.products.retrieve.resolves({active: false});
 
       const result = await service.checkProductExists('prod_archived_002');
 
-      expect(result).to.be.false();
+      expect(result).to.be.false;
     });
 
     it('returns false when Stripe signals resource_missing', async () => {
@@ -662,7 +662,7 @@ describe('StripeService - Subscription Management', () => {
 
       const result = await service.checkProductExists('prod_gone_003');
 
-      expect(result).to.be.false();
+      expect(result).to.be.false;
     });
 
     it('re-throws unexpected errors from Stripe', async () => {

src/providers/sdk/chargebee/charge-bee.service.ts

@@ -321,6 +321,13 @@ export class ChargeBeeService implements IChargeBeeService {
         .replaceAll(/[^a-z0-9]+/g, '-')
         .replaceAll(/^-|-$/g, '');
 
+      if (!itemId) {
+        throw new Error(
+          `Cannot derive a valid Chargebee item ID from product name "${product.name}". ` +
+            'The name must contain at least one alphanumeric character.',
+        );
+      }
+
       // Strip item_family_id from metadata — it is a top-level Chargebee param,
       // and Chargebee rejects it if it appears inside metadata.
       // eslint-disable-next-line @typescript-eslint/no-unused-vars

src/providers/sdk/chargebee/type/chargebee-config.type.ts

@@ -18,9 +18,8 @@ export interface ChargeBeeConfig {
   /**
    * Pricing model applied when creating ItemPrices.
    * Defaults to `'flat_fee'` (single fixed recurring charge).
-   * Other Chargebee values: `'per_unit'`, `'tiered'`, `'volume'`, `'stairstep'`.
    */
-  defaultPricingModel?: string;
+  defaultPricingModel?: ChargebeePricingModel;
 
   /**
    * When `true`, subscriptions are cancelled at the end of the current billing