feat(chore): fix comments

fix comments

GH-27

Author: Sourav-kashyap

src/providers/sdk/chargebee/adapter/payment-intent.adapter.ts

@@ -1,18 +1,23 @@
-import {TPaymentIntent, TPaymentMethod} from '../../../../types';
+import {PaymentStatus, TPaymentIntent, TPaymentMethod} from '../../../../types';
 import {
   ChargebeeCard,
   ChargebeePaymentSource,
   ChargebeeTransaction,
+  ChargebeeCardDefaults,
 } from '../type';
 
-// Payment method default values
-const DEFAULT_EXPIRY_MONTH = 12;
-const DEFAULT_EXPIRY_YEAR = 2025;
-const DEFAULT_FUNDING_TYPE = 'credit';
-const DEFAULT_CARD_BRAND = 'unknown';
-
 export class ChargebeePaymentIntentAdapter {
-  constructor() {}
+  private readonly cardDefaults: Required<ChargebeeCardDefaults>;
+
+  constructor(cardDefaults?: ChargebeeCardDefaults) {
+    const currentYear = new Date().getFullYear();
+    this.cardDefaults = {
+      defaultExpiryMonth: cardDefaults?.defaultExpiryMonth ?? 12,
+      defaultExpiryYear: cardDefaults?.defaultExpiryYear ?? currentYear,
+      defaultFundingType: cardDefaults?.defaultFundingType ?? 'credit',
+      defaultCardBrand: cardDefaults?.defaultCardBrand ?? 'unknown',
+    };
+  }
 
   /**
    * Adapts a ChargeBee transaction to the generic TPaymentIntent format.
@@ -101,24 +106,24 @@ export class ChargebeePaymentIntentAdapter {
    */
   private mapTransactionStatusToPaymentIntentStatus(
     transactionStatus: string,
-  ): string {
+  ): PaymentStatus {
     switch (transactionStatus) {
       case 'in_progress':
-        return 'processing';
+        return PaymentStatus.PROCESSING;
       case 'success':
-        return 'succeeded';
+        return PaymentStatus.SUCCEEDED;
       case 'voided':
-        return 'canceled';
+        return PaymentStatus.CANCELED;
       case 'failure':
-        return 'canceled';
+        return PaymentStatus.CANCELED;
       case 'timeout':
-        return 'canceled';
+        return PaymentStatus.CANCELED;
       case 'needs_attention':
-        return 'requires_action';
+        return PaymentStatus.REQUIRES_ACTION;
       case 'late_failure':
-        return 'canceled';
+        return PaymentStatus.CANCELED;
       default:
-        return 'requires_payment_method';
+        return PaymentStatus.REQUIRES_PAYMENT_METHOD;
     }
   }
 
@@ -158,9 +163,9 @@ export class ChargebeePaymentIntentAdapter {
     return {
       brand: this.getCardBrand(card),
       last4: card.last4 ?? '****',
-      expMonth: card.expiryMonth ?? DEFAULT_EXPIRY_MONTH,
-      expYear: card.expiryYear ?? DEFAULT_EXPIRY_YEAR,
-      funding: card.funding ?? DEFAULT_FUNDING_TYPE,
+      expMonth: card.expiryMonth ?? this.cardDefaults.defaultExpiryMonth,
+      expYear: card.expiryYear ?? this.cardDefaults.defaultExpiryYear,
+      funding: card.funding ?? this.cardDefaults.defaultFundingType,
     };
   }
 
@@ -174,7 +179,7 @@ export class ChargebeePaymentIntentAdapter {
     if (card.firstSixDigits) {
       return this.detectCardBrand(card.firstSixDigits);
     }
-    return DEFAULT_CARD_BRAND;
+    return this.cardDefaults.defaultCardBrand;
   }
 
   /**

src/providers/sdk/chargebee/charge-bee.service.ts

@@ -65,7 +65,9 @@ export class ChargeBeeService implements IChargeBeeService {
     this.customerAdapter = new CustomerAdapter();
     this.paymentSource = new PaymentSourceAdapter();
     this.chargebeeSubscriptionAdapter = new ChargebeeSubscriptionAdapter();
-    this.chargebeePaymentIntentAdapter = new ChargebeePaymentIntentAdapter();
+    this.chargebeePaymentIntentAdapter = new ChargebeePaymentIntentAdapter(
+      chargeBeeConfig.cardDefaults,
+    );
   }
   async createCustomer(
     customerDto: IChargeBeeCustomer,

src/providers/sdk/chargebee/type/chargebee-config.type.ts

@@ -1,3 +1,18 @@
+/**
+ * Card default values for when card data is missing from the provider response.
+ * These should only be used as fallbacks when payment providers return incomplete data.
+ */
+export interface ChargebeeCardDefaults {
+  /** Default expiry month (1-12). Defaults to 12. */
+  defaultExpiryMonth?: number;
+  /** Default expiry year. Defaults to current year. */
+  defaultExpiryYear?: number;
+  /** Default funding type. Defaults to 'credit'. */
+  defaultFundingType?: string;
+  /** Default card brand. Defaults to 'unknown'. */
+  defaultCardBrand?: string;
+}
+
 /**
  * Configuration for the Chargebee billing provider.
  *
@@ -34,6 +49,11 @@ export interface ChargeBeeConfig {
    * Must be one of the reason codes configured on your Chargebee site.
    */
   defaultCancelReasonCode?: string;
+  /**
+   * Card default values for fallback when provider returns incomplete card data.
+   * These should rarely be needed with valid Chargebee responses.
+   */
+  cardDefaults?: ChargebeeCardDefaults;
 }
 
 export type ChargebeePricingModel =

src/providers/sdk/stripe/adapter/payment-intent.adapter.ts

@@ -1,5 +1,5 @@
 import Stripe from 'stripe';
-import {TPaymentIntent, TPaymentMethod} from '../../../../types';
+import {PaymentStatus, TPaymentIntent, TPaymentMethod} from '../../../../types';
 
 export class StripePaymentIntentAdapter {
   constructor() {}
@@ -19,7 +19,7 @@ export class StripePaymentIntentAdapter {
       id: paymentIntent.id,
       amount: paymentIntent.amount,
       currency: paymentIntent.currency,
-      status: paymentIntent.status,
+      status: paymentIntent.status as PaymentStatus,
       created: paymentIntent.created,
       customer: (paymentIntent.customer as string) ?? undefined,
       paymentMethod: paymentMethod,

src/providers/sdk/stripe/adapter/payment-source.adapter.ts

@@ -1,16 +1,24 @@
 import Stripe from 'stripe';
 import {AnyObject} from '@loopback/repository';
 import {TPaymentMethod, IAdapter} from '../../../../types';
-import {IStripePaymentSource, StripeLegacySource} from '../type';
-
-// Payment method default values
-const DEFAULT_EXPIRY_MONTH = 12;
-const DEFAULT_EXPIRY_YEAR = 2025;
-const DEFAULT_FUNDING_TYPE = 'credit';
-const DEFAULT_CARD_BRAND = 'unknown';
+import {
+  IStripePaymentSource,
+  StripeLegacySource,
+  StripeCardDefaults,
+} from '../type';
 
 export class StripePaymentAdapter implements IAdapter<IStripePaymentSource> {
-  constructor() {}
+  private readonly cardDefaults: Required<StripeCardDefaults>;
+
+  constructor(cardDefaults?: StripeCardDefaults) {
+    const currentYear = new Date().getFullYear();
+    this.cardDefaults = {
+      defaultExpiryMonth: cardDefaults?.defaultExpiryMonth ?? 12,
+      defaultExpiryYear: cardDefaults?.defaultExpiryYear ?? currentYear,
+      defaultFundingType: cardDefaults?.defaultFundingType ?? 'credit',
+      defaultCardBrand: cardDefaults?.defaultCardBrand ?? 'unknown',
+    };
+  }
 
   adaptToModel(resp: AnyObject): IStripePaymentSource {
     return {
@@ -78,11 +86,11 @@ export class StripePaymentAdapter implements IAdapter<IStripePaymentSource> {
         type: 'card',
         id: source.id,
         card: {
-          brand: card.brand || DEFAULT_CARD_BRAND,
+          brand: card.brand || this.cardDefaults.defaultCardBrand,
           last4: card.last4 || '****',
-          expMonth: card.expMonth || DEFAULT_EXPIRY_MONTH,
-          expYear: card.expYear || DEFAULT_EXPIRY_YEAR,
-          funding: card.funding || DEFAULT_FUNDING_TYPE,
+          expMonth: card.expMonth || this.cardDefaults.defaultExpiryMonth,
+          expYear: card.expYear || this.cardDefaults.defaultExpiryYear,
+          funding: card.funding || this.cardDefaults.defaultFundingType,
         },
       };
     }

src/providers/sdk/stripe/stripe.service.ts

@@ -55,7 +55,9 @@ export class StripeService implements IStripeService {
     });
     this.stripeCustomerAdapter = new StripeCustomerAdapter();
     this.stripeInvoiceAdapter = new StripeInvoiceAdapter();
-    this.stripePaymentAdapter = new StripePaymentAdapter();
+    this.stripePaymentAdapter = new StripePaymentAdapter(
+      stripeConfig.cardDefaults,
+    );
     this.stripeSubscriptionAdapter = new StripeSubscriptionAdapter();
     this.stripePaymentIntentAdapter = new StripePaymentIntentAdapter();
   }

src/providers/sdk/stripe/type/stripe-config.type.ts

@@ -1,4 +1,20 @@
 import Stripe from 'stripe';
+
+/**
+ * Card default values for when card data is missing from the provider response.
+ * These should only be used as fallbacks when payment providers return incomplete data.
+ */
+export interface StripeCardDefaults {
+  /** Default expiry month (1-12). Defaults to 12. */
+  defaultExpiryMonth?: number;
+  /** Default expiry year. Defaults to current year. */
+  defaultExpiryYear?: number;
+  /** Default funding type. Defaults to 'credit'. */
+  defaultFundingType?: string;
+  /** Default card brand. Defaults to 'unknown'. */
+  defaultCardBrand?: string;
+}
+
 export interface StripeConfig {
   secretKey: string;
   /**
@@ -13,6 +29,11 @@ export interface StripeConfig {
    * @see https://stripe.com/docs/api/subscriptions/create#create_subscription-payment_behavior
    */
   defaultPaymentBehavior?: Stripe.SubscriptionCreateParams.PaymentBehavior;
+  /**
+   * Card default values for fallback when provider returns incomplete card data.
+   * These should rarely be needed with valid Stripe responses.
+   */
+  cardDefaults?: StripeCardDefaults;
 }
 
 /**

src/types.ts

@@ -167,6 +167,19 @@ export enum ProrationBehavior {
   ALWAYS_INVOICE = 'always_invoice',
 }
 
+/**
+ * Payment intent status values
+ */
+export enum PaymentStatus {
+  REQUIRES_PAYMENT_METHOD = 'requires_payment_method',
+  REQUIRES_CONFIRMATION = 'requires_confirmation',
+  REQUIRES_ACTION = 'requires_action',
+  PROCESSING = 'processing',
+  REQUIRES_CAPTURE = 'requires_capture',
+  CANCELED = 'canceled',
+  SUCCEEDED = 'succeeded',
+}
+
 /**
  * Parameters required to create a product in the billing provider.
  */
@@ -269,6 +282,38 @@ export interface TInvoicePdf {
   generatedAt: number;
 }
 
+/**
+ * Card payment method details
+ */
+export interface TCard {
+  /** Card brand: visa, mastercard, amex, etc. */
+  brand: string;
+  /** Last 4 digits */
+  last4: string;
+  /** Expiration month */
+  expMonth: number;
+  /** Expiration year */
+  expYear: number;
+  /** Funding type: credit, debit, prepaid, unknown */
+  funding: string;
+  /** Country code */
+  country?: string;
+}
+
+/**
+ * Bank account payment method details
+ */
+export interface TBankAccount {
+  /** Bank name */
+  bankName: string;
+  /** Last 4 digits */
+  last4: string;
+  /** Routing number */
+  routingNumber?: string;
+  /** Account type: checking, savings */
+  accountType?: string;
+}
+
 /**
  * Represents payment method details (card, bank account, etc.)
  */
@@ -277,32 +322,10 @@ export interface TPaymentMethod {
   type: string;
 
   /** Card details (if type is card) */
-  card?: {
-    /** Card brand: visa, mastercard, amex, etc. */
-    brand: string;
-    /** Last 4 digits */
-    last4: string;
-    /** Expiration month */
-    expMonth: number;
-    /** Expiration year */
-    expYear: number;
-    /** Funding type: credit, debit, prepaid, unknown */
-    funding: string;
-    /** Country code */
-    country?: string;
-  };
+  card?: TCard;
 
   /** Bank account details (if type is bank_account) */
-  bankAccount?: {
-    /** Bank name */
-    bankName: string;
-    /** Last 4 digits */
-    last4: string;
-    /** Routing number */
-    routingNumber?: string;
-    /** Account type: checking, savings */
-    accountType?: string;
-  };
+  bankAccount?: TBankAccount;
 
   /** Customer ID */
   customer?: string;
@@ -363,7 +386,7 @@ export interface TPaymentIntent {
    * - canceled
    * - succeeded
    */
-  status: string;
+  status: PaymentStatus;
 
   /** Creation timestamp (seconds) */
   created: number;