feat(chore): sonar fix

sonar fix

GH-27

Author: Sourav-kashyap

src/providers/sdk/chargebee/adapter/invoice.adapter.ts

@@ -3,9 +3,8 @@ import {
   TInvoicePaymentDetails,
   TPaymentMethod,
 } from '../../../../types';
-import {ChargebeeInvoice} from '../type';
+import {ChargebeeInvoice, ICharge, IChargeBeeInvoice, IDiscount} from '../type';
 import {AnyObject} from '@loopback/repository';
-import {ICharge, IChargeBeeInvoice, IDiscount} from '../type';
 export class InvoiceAdapter {
   constructor() {}
 
@@ -56,9 +55,11 @@ export class InvoiceAdapter {
     download: Record<string, unknown>,
     invoiceId: string,
   ): TInvoicePdf {
+    const downloadUrl = download['download_url'];
+    const pdfUrl = typeof downloadUrl === 'string' ? downloadUrl : '';
     return {
       invoiceId: invoiceId,
-      pdfUrl: String(download['download_url'] ?? ''),
+      pdfUrl: pdfUrl,
       generatedAt: Math.floor(Date.now() / 1000), // Current timestamp in seconds
       expiresAt: download['expires_at'] as number | undefined,
     };

src/providers/sdk/chargebee/adapter/payment-intent.adapter.ts

@@ -25,35 +25,20 @@ export class ChargebeePaymentIntentAdapter {
     transaction: ChargebeeTransaction,
     paymentMethod?: TPaymentMethod,
   ): TPaymentIntent {
-    const currencyCode =
-      ((transaction as Record<string, unknown>)['currency_code'] as
-        | string
-        | undefined) ??
-      transaction.currencyCode ??
-      'usd';
-    const customerId =
-      ((transaction as Record<string, unknown>)['customer_id'] as
-        | string
-        | undefined) ?? transaction.customerId;
-    const amountCapturable = (transaction as Record<string, unknown>)[
-      'amount_capturable'
-    ] as number | undefined;
-    const transactionType =
-      ((transaction as Record<string, unknown>)['type'] as
-        | string
-        | undefined) ?? 'transaction';
+    const currencyCode = this.extractCurrencyCode(transaction);
+    const customerId = this.extractCustomerId(transaction);
+    const amountCapturable = this.extractAmountCapturable(transaction);
+    const transactionType = this.extractTransactionType(transaction);
+    const created = this.extractCreatedTimestamp(transaction);
 
     return {
       id: transaction.id ?? '',
       amount: transaction.amount ?? 0,
-      currency: String(currencyCode).toLowerCase(),
+      currency: currencyCode.toLowerCase(),
       status: this.mapTransactionStatusToPaymentIntentStatus(
         transaction.status ?? 'in_progress',
       ),
-      created:
-        typeof transaction.date === 'string'
-          ? Math.floor(new Date(transaction.date).getTime() / 1000)
-          : (transaction.date ?? 0),
+      created: created,
       customer: customerId,
       paymentMethod: paymentMethod,
       description: `ChargeBee ${transactionType} transaction`,
@@ -64,6 +49,47 @@ export class ChargebeePaymentIntentAdapter {
     };
   }
 
+  private extractCurrencyCode(transaction: ChargebeeTransaction): string {
+    const currencyCode =
+      ((transaction as Record<string, unknown>)['currency_code'] as
+        | string
+        | undefined) ?? transaction.currencyCode;
+    return currencyCode ?? 'usd';
+  }
+
+  private extractCustomerId(
+    transaction: ChargebeeTransaction,
+  ): string | undefined {
+    return (
+      ((transaction as Record<string, unknown>)['customer_id'] as
+        | string
+        | undefined) ?? transaction.customerId
+    );
+  }
+
+  private extractAmountCapturable(
+    transaction: ChargebeeTransaction,
+  ): number | undefined {
+    return (transaction as Record<string, unknown>)['amount_capturable'] as
+      | number
+      | undefined;
+  }
+
+  private extractTransactionType(transaction: ChargebeeTransaction): string {
+    return (
+      ((transaction as Record<string, unknown>)['type'] as
+        | string
+        | undefined) ?? 'transaction'
+    );
+  }
+
+  private extractCreatedTimestamp(transaction: ChargebeeTransaction): number {
+    if (typeof transaction.date === 'string') {
+      return Math.floor(new Date(transaction.date).getTime() / 1000);
+    }
+    return transaction.date ?? 0;
+  }
+
   /**
    * Maps ChargeBee transaction status to PaymentIntent status.
    *

src/providers/sdk/stripe/adapter/payment-source.adapter.ts

@@ -1,7 +1,6 @@
 import Stripe from 'stripe';
 import {AnyObject} from '@loopback/repository';
-import {TPaymentMethod} from '../../../../types';
-import {IAdapter} from '../../../../types';
+import {TPaymentMethod, IAdapter} from '../../../../types';
 import {IStripePaymentSource, StripeLegacySource} from '../type';
 
 // Payment method default values