feat(query-generation): sonar fixes

Author: akshatdubeysf

src/components/db-query/db-query.graph.ts

@@ -170,34 +170,38 @@ export class DbQueryGraph extends BaseGraph<DbQueryState> {
   }
 
   private _mergeValidationResults(state: DbQueryState) {
-    const hasSyntacticFailure =
-      state.syntacticStatus && state.syntacticStatus !== EvaluationResult.Pass;
-    const hasSemanticFailure =
-      state.semanticStatus && state.semanticStatus !== EvaluationResult.Pass;
+    const hasSyntacticFailure = this._isValidationFailure(
+      state.syntacticStatus,
+    );
+    const hasSemanticFailure = this._isValidationFailure(state.semanticStatus);
 
     if (!hasSyntacticFailure && !hasSemanticFailure) {
       return this._buildPassedResult(state);
     }
 
+    return this._buildFailedResult(state, hasSyntacticFailure);
+  }
+
+  private _isValidationFailure(status: DbQueryState['syntacticStatus']) {
+    return !!status && status !== EvaluationResult.Pass;
+  }
+
+  private _buildFailedResult(
+    state: DbQueryState,
+    hasSyntacticFailure: boolean,
+  ) {
     const clearedState = this._buildClearedState(state);
     const baseFeedbacks = state.feedbacks ?? [];
     const semanticFb = this._toArray(state.semanticFeedback);
-
-    if (hasSyntacticFailure) {
-      return {
-        status: state.syntacticStatus,
-        feedbacks: [
-          ...baseFeedbacks,
-          ...this._toArray(state.syntacticFeedback),
-          ...semanticFb,
-        ],
-        ...clearedState,
-      };
-    }
+    const syntacticFb = hasSyntacticFailure
+      ? this._toArray(state.syntacticFeedback)
+      : [];
 
     return {
-      status: state.semanticStatus,
-      feedbacks: [...baseFeedbacks, ...semanticFb],
+      status: hasSyntacticFailure
+        ? state.syntacticStatus
+        : state.semanticStatus,
+      feedbacks: [...baseFeedbacks, ...syntacticFb, ...semanticFb],
       ...clearedState,
     };
   }

src/components/db-query/services/template-helper.service.ts

@@ -286,14 +286,18 @@ Do not return any other text or explanation, just the XML tags.
   }
 
   private _formatValue(type: string, value: string | null): string {
-    const formatters: Record<string, (v: string | null) => string> = {
-      string: v => `'${(v ?? '').replace(/'/g, "''")}'`,
-      number: v => `${Number(v) || 0}`,
-      boolean: v => (this._isTruthy(v) ? 'TRUE' : 'FALSE'),
-      // eslint-disable-next-line @typescript-eslint/naming-convention
-      sql_expression: v => v ?? '1=1',
-    };
-    return (formatters[type] ?? (v => v ?? ''))(value);
+    switch (type) {
+      case 'string':
+        return `'${(value ?? '').replace(/'/g, "''")}'`;
+      case 'number':
+        return `${Number(value) || 0}`;
+      case 'boolean':
+        return this._isTruthy(value) ? 'TRUE' : 'FALSE';
+      case 'sql_expression':
+        return value ?? '1=1';
+      default:
+        return value ?? '';
+    }
   }
 
   private _isTruthy(value: string | null): boolean {