fix(ci-cd): sonar issues fix

sonar issues fix

GH-14

Author: vinaygupta-sourcefuse

src/__tests__/integration/mcp-tool.integration.ts

@@ -4,6 +4,9 @@ import {McpServerFactory} from '../../services/mcp-server-factory.service';
 import {McpToolRegistry} from '../../services/mcp-tool-registry.service';
 import {McpServer} from '@modelcontextprotocol/sdk/server/mcp.js';
 
+// Test constants to avoid magic numbers
+const TEST_NUMBERS = [1, 2, 3];
+
 describe('McpServerFactory (integration)', () => {
   let ctx: Context;
   let toolRegistry: McpToolRegistry;
@@ -150,7 +153,7 @@ describe('McpServerFactory (integration)', () => {
 
       const arrayParams: Record<string, unknown> = {
         items: ['item1', 'item2', 'item3'],
-        numbers: [1, 2, 3],
+        numbers: TEST_NUMBERS,
       };
 
       for (const [key, value] of Object.entries(arrayParams)) {

src/services/mcp-server-factory.service.ts

@@ -45,19 +45,19 @@ export class McpServerFactory {
         // Handle common double-wrapping patterns
         const cleanedParameters: Record<string, unknown> = {};
         for (const [key, value] of Object.entries(parameters)) {
-          if (value && typeof value === 'object') {
-            const valueObj = value as Record<string, unknown>;
-
-            // Pattern: Parameter value wrapped in object with same key
-            // e.g., "currency": {"currency": {...actual data...}}
-            if (key in valueObj && Object.keys(valueObj).length === 1) {
-              cleanedParameters[key] = valueObj[key];
-            } else {
-              cleanedParameters[key] = value;
-            }
-          } else {
+          // Skip non-objects and null/undefined values
+          if (!value || typeof value !== 'object') {
             cleanedParameters[key] = value;
+            continue;
           }
+
+          const valueObj = value as Record<string, unknown>;
+          // Pattern: Parameter value wrapped in object with same key
+          // e.g., "currency": {"currency": {...actual data...}}
+          cleanedParameters[key] =
+            key in valueObj && Object.keys(valueObj).length === 1
+              ? valueObj[key]
+              : value;
         }
 
         const result = await toolDef.handler(