Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a helper function to override model JSON schemas via metadata and exposes it in the core package.
- Added a new
build-schemamodule export inindex.ts. - Defined
OVERRIDE_MODEL_SCHEMA_KEYand implementedgetModelSchemaRefSFinbuild-schema.tsto use override metadata when generating a model’s JSON schema reference.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/index.ts | Exported the new build-schema module |
| packages/core/src/build-schema.ts | Added metadata key and helper function to override model schemas |
Comments suppressed due to low confidence (3)
packages/core/src/build-schema.ts:18
- [nitpick] The function name
getModelSchemaRefSFis ambiguous; consider renaming it to something more descriptive likegetModelSchemaWithOverrideRefto clarify its purpose.
export function getModelSchemaRefSF<T extends object>(
packages/core/src/build-schema.ts:10
- This comment refers to repository JSON schemas but the key is for overriding model schemas; please update it to accurately describe its intent.
* Metadata key used to set or retrieve repository JSON Schema
packages/core/src/build-schema.ts:18
- Add unit tests for
getModelSchemaRefSFto verify both default schema generation and the override behavior when metadata is present.
export function getModelSchemaRefSF<T extends object>(
akshatdubeysf
requested changes
Jun 25, 2025
akshatdubeysf
approved these changes
Jul 4, 2025
add helper function for override schema of models gh-86
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



add helper function for override schema of models
gh-86
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: