Skip to content

signoz fix#6

Merged
vijay-stephen merged 2 commits into
mainfrom
feature/signoz-update
Apr 30, 2026
Merged

signoz fix#6
vijay-stephen merged 2 commits into
mainfrom
feature/signoz-update

Conversation

@Arunsai14

Copy link
Copy Markdown
Contributor

Description

Please provide a brief description of the changes introduced by this pull request.

Related Issue

Checklist

Please ensure that the following steps are completed before submitting the pull request:

  • Code follows the Terraform best practices and style guidelines.
  • Changes are appropriately documented, including any necessary updates to README or other documentation files.
  • Unit tests have been added or updated to cover the changes introduced by this pull request.
  • Changes have been tested locally and verified to work as expected.
  • The code has been reviewed to ensure it aligns with the project's goals and standards.
  • Dependencies and backward compatibility have been considered and addressed if applicable.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Testing Instructions

Provide detailed steps or instructions for testing the changes introduced by this pull request.

Screenshots

Include any relevant screenshots or visual aids to help reviewers understand the changes visually, if applicable.

Additional Notes

Add any additional notes or context that might be helpful for reviewers or users testing the changes.

@sonarqubecloud

Copy link
Copy Markdown

SonarQube reviewer guide

Summary: Add Hashicorp Time provider and update SigNoz deployment configuration including chart version bump, Kubernetes authentication method, and ALB hostname handling improvements.

Review Focus:

  • Kubernetes provider authentication change from deprecated aws_eks_cluster_auth data source to exec block—verify this works reliably in your CI/CD environment
  • SigNoz Helm chart upgrade from 0.78.0 to 0.118.0 with template changes—review the signoz.tftpl template for breaking changes and ensure backward compatibility
  • New time_sleep resource addition for ALB provisioning (120s delay)—confirm this timing is sufficient for your infrastructure
  • New optional alb_hostname parameter that bypasses ingress lookup—ensure documentation is clear on when to use this

Start review at: modules/signoz/main.tf. This file contains the core logic changes including the new time_sleep resource, updated ingress data source conditions, and Route53 record creation logic that now supports both dynamic ingress lookup and static hostname input. These are critical for correct deployment behavior.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vijay-stephen vijay-stephen merged commit 6c230d7 into main Apr 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants