Skip to content

update readme and workflows#7

Merged
manikanta-sadurla merged 2 commits into
mainfrom
feature/update-readme
Jun 5, 2026
Merged

update readme and workflows#7
manikanta-sadurla merged 2 commits into
mainfrom
feature/update-readme

Conversation

@manikanta-sadurla

Copy link
Copy Markdown
Contributor

Description

Please provide a brief description of the changes introduced by this pull request.

Related Issue

Checklist

Please ensure that the following steps are completed before submitting the pull request:

  • Code follows the Terraform best practices and style guidelines.
  • Changes are appropriately documented, including any necessary updates to README or other documentation files.
  • Unit tests have been added or updated to cover the changes introduced by this pull request.
  • Changes have been tested locally and verified to work as expected.
  • The code has been reviewed to ensure it aligns with the project's goals and standards.
  • Dependencies and backward compatibility have been considered and addressed if applicable.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Testing Instructions

Provide detailed steps or instructions for testing the changes introduced by this pull request.

Screenshots

Include any relevant screenshots or visual aids to help reviewers understand the changes visually, if applicable.

Additional Notes

Add any additional notes or context that might be helpful for reviewers or users testing the changes.

@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

SonarQube reviewer guide

Summary: Add security scanning automation and improve documentation for the Terraform observability module.

Review Focus:

  1. README.md has significant duplication — the Contributing/Authors sections are repeated multiple times at the end, indicating a merge conflict or editing error that needs cleanup.
  2. Trivy workflow configuration — verify the exit-code: 1 setting will properly fail the build on HIGH/CRITICAL vulnerabilities as intended.

Start review at: README.md. The file contains duplicate sections that must be consolidated before merge, and the documentation restructuring should be validated for clarity and completeness.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vijay-stephen vijay-stephen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manikanta-sadurla manikanta-sadurla merged commit e771174 into main Jun 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants