fix: escape BRE special characters when selecting author from suggestions (#2494)

Author: JC-Chung

src/App.Extensions.cs

@@ -18,6 +18,18 @@ public static string Escaped(this string value)
             return value.Replace("\"", "\\\"", StringComparison.Ordinal);
         }
 
+        public static string EscapeForBRE(this string value)
+        {
+            return value
+                .Replace("\\", "\\\\", StringComparison.Ordinal)
+                .Replace(".", "\\.", StringComparison.Ordinal)
+                .Replace("[", "\\[", StringComparison.Ordinal)
+                .Replace("*", "\\*", StringComparison.Ordinal)
+                .Replace("^", "\\^", StringComparison.Ordinal)
+                .Replace("$", "\\$", StringComparison.Ordinal)
+                .Replace("{", "\\{", StringComparison.Ordinal);
+        }
+
         public static string FormatFontNames(string input)
         {
             if (string.IsNullOrEmpty(input))

src/ViewModels/SearchCommitContext.cs

@@ -27,6 +27,7 @@ public string Filter
             get => _filter;
             set
             {
+                _isLiteralFilter = false;
                 if (SetProperty(ref _filter, value))
                     UpdateSuggestions();
             }
@@ -82,6 +83,14 @@ public void ClearFilter()
             Results = null;
         }
 
+        public void SetLiteralFilter(string filter)
+        {
+            _isLiteralFilter = true;
+            _filter = filter;
+            OnPropertyChanged(nameof(Filter));
+            UpdateSuggestions();
+        }
+
         public void ClearSuggestions()
         {
             Suggestions = null;
@@ -109,6 +118,9 @@ public void StartSearch()
                 var result = new List<Models.Commit>();
                 var method = (Models.CommitSearchMethod)_method;
                 var repoPath = _repo.FullPath;
+                var filter = (_isLiteralFilter && method == Models.CommitSearchMethod.ByAuthor)
+                    ? _filter.EscapeForBRE()
+                    : _filter;
 
                 if (method == Models.CommitSearchMethod.BySHA)
                 {
@@ -131,7 +143,7 @@ public void StartSearch()
                 }
                 else if (_onlySearchCurrentBranch)
                 {
-                    result = await new Commands.QueryCommits(repoPath, _filter, method, true)
+                    result = await new Commands.QueryCommits(repoPath, filter, method, true)
                         .GetResultAsync()
                         .ConfigureAwait(false);
 
@@ -140,7 +152,7 @@ public void StartSearch()
                 }
                 else
                 {
-                    result = await new Commands.QueryCommits(repoPath, _filter, method, false)
+                    result = await new Commands.QueryCommits(repoPath, filter, method, false)
                         .GetResultAsync()
                         .ConfigureAwait(false);
 
@@ -290,6 +302,7 @@ private void UpdateSuggestions()
         private int _method = (int)Models.CommitSearchMethod.ByMessage;
         private string _filter = string.Empty;
         private bool _onlySearchCurrentBranch = false;
+        private bool _isLiteralFilter = false;
         private bool _isQuerying = false;
         private List<Models.Commit> _results = null;
         private Models.Commit _selected = null;

src/Views/Repository.axaml.cs

@@ -328,7 +328,7 @@ private void OnSearchSuggestionBoxKeyDown(object _, KeyEventArgs e)
                 else if (selected is Models.User user)
                 {
                     var apply = user.ToString();
-                    repo.SearchCommitContext.Filter = apply;
+                    repo.SearchCommitContext.SetLiteralFilter(apply);
                     TxtSearchCommitsBox.CaretIndex = apply.Length;
                 }
 
@@ -351,7 +351,7 @@ private void OnSearchSuggestionTapped(object sender, TappedEventArgs e)
             else if (ctx is Models.User user)
             {
                 var apply = user.ToString();
-                repo.SearchCommitContext.Filter = apply;
+                repo.SearchCommitContext.SetLiteralFilter(apply);
                 TxtSearchCommitsBox.CaretIndex = apply.Length;
             }