code_review: PR #2494

Since `EscapeForBRE` is only used when selecting item in suggestion popup (and the
searching command runs immediately after it), directly call `EscapeForBRE` to generate
the searching filter

Signed-off-by: leo <longshuang@msn.cn>

Author: love-linger

src/ViewModels/SearchCommitContext.cs

@@ -27,7 +27,6 @@ public string Filter
             get => _filter;
             set
             {
-                _isLiteralFilter = false;
                 if (SetProperty(ref _filter, value))
                     UpdateSuggestions();
             }
@@ -83,14 +82,6 @@ public void ClearFilter()
             Results = null;
         }
 
-        public void SetLiteralFilter(string filter)
-        {
-            _isLiteralFilter = true;
-            _filter = filter;
-            OnPropertyChanged(nameof(Filter));
-            UpdateSuggestions();
-        }
-
         public void ClearSuggestions()
         {
             Suggestions = null;
@@ -118,9 +109,6 @@ public void StartSearch()
                 var result = new List<Models.Commit>();
                 var method = (Models.CommitSearchMethod)_method;
                 var repoPath = _repo.FullPath;
-                var filter = (_isLiteralFilter && method == Models.CommitSearchMethod.ByAuthor)
-                    ? _filter.EscapeForBRE()
-                    : _filter;
 
                 if (method == Models.CommitSearchMethod.BySHA)
                 {
@@ -143,7 +131,7 @@ public void StartSearch()
                 }
                 else if (_onlySearchCurrentBranch)
                 {
-                    result = await new Commands.QueryCommits(repoPath, filter, method, true)
+                    result = await new Commands.QueryCommits(repoPath, _filter, method, true)
                         .GetResultAsync()
                         .ConfigureAwait(false);
 
@@ -152,7 +140,7 @@ public void StartSearch()
                 }
                 else
                 {
-                    result = await new Commands.QueryCommits(repoPath, filter, method, false)
+                    result = await new Commands.QueryCommits(repoPath, _filter, method, false)
                         .GetResultAsync()
                         .ConfigureAwait(false);
 
@@ -302,7 +290,6 @@ private void UpdateSuggestions()
         private int _method = (int)Models.CommitSearchMethod.ByMessage;
         private string _filter = string.Empty;
         private bool _onlySearchCurrentBranch = false;
-        private bool _isLiteralFilter = false;
         private bool _isQuerying = false;
         private List<Models.Commit> _results = null;
         private Models.Commit _selected = null;

src/Views/Repository.axaml.cs

@@ -327,8 +327,8 @@ private void OnSearchSuggestionBoxKeyDown(object _, KeyEventArgs e)
                 }
                 else if (selected is Models.User user)
                 {
-                    var apply = user.ToString();
-                    repo.SearchCommitContext.SetLiteralFilter(apply);
+                    var apply = user.ToString().EscapeForBRE();
+                    repo.SearchCommitContext.Filter = apply;
                     TxtSearchCommitsBox.CaretIndex = apply.Length;
                 }
 
@@ -350,8 +350,8 @@ private void OnSearchSuggestionTapped(object sender, TappedEventArgs e)
             }
             else if (ctx is Models.User user)
             {
-                var apply = user.ToString();
-                repo.SearchCommitContext.SetLiteralFilter(apply);
+                var apply = user.ToString().EscapeForBRE();
+                repo.SearchCommitContext.Filter = apply;
                 TxtSearchCommitsBox.CaretIndex = apply.Length;
             }