code_style: remove DirectoryInfoExtension.GetRelativePath since it is not safe while being used out of DirectoryInfoExtension.WalkFiles

Signed-off-by: leo <longshuang@msn.cn>

Author: love-linger

src/App.Extensions.cs

@@ -57,10 +57,5 @@ public static void WalkFiles(this DirectoryInfo dir, Action<string> onFile, int
                 // Ignore exceptions.
             }
         }
-
-        public static string GetRelativePath(this DirectoryInfo dir, string fullpath)
-        {
-            return fullpath.Substring(dir.FullName.Length).TrimStart(Path.DirectorySeparatorChar);
-        }
     }
 }

src/Models/ExternalTool.cs

@@ -230,10 +230,14 @@ public void FindJetBrainsFromToolbox(Func<string> platformFinder)
                 return null;
 
             var options = new List<ExternalTool.LaunchOption>();
+            var prefixLen = root.FullName.Length;
             root.WalkFiles(f =>
             {
                 if (f.EndsWith(".code-workspace", StringComparison.OrdinalIgnoreCase))
-                    options.Add(new(root.GetRelativePath(f), f.Quoted()));
+                {
+                    var display = f.Substring(prefixLen).TrimStart(Path.DirectorySeparatorChar);
+                    options.Add(new(display, f.Quoted()));
+                }
             }, 2);
             return options;
         }

src/Native/Windows.cs

@@ -234,11 +234,15 @@ private void FixWindowFrameOnWin10(Window w)
                 return null;
 
             var options = new List<Models.ExternalTool.LaunchOption>();
+            var prefixLen = root.FullName.Length;
             root.WalkFiles(f =>
             {
                 if (f.EndsWith(".sln", StringComparison.OrdinalIgnoreCase) ||
                     f.EndsWith(".slnx", StringComparison.OrdinalIgnoreCase))
-                    options.Add(new(root.GetRelativePath(f), f.Quoted()));
+                {
+                    var display = f.Substring(prefixLen).TrimStart(Path.DirectorySeparatorChar);
+                    options.Add(new(display, f.Quoted()));
+                }
             });
             return options;
         }