refactor: re-design command palette API

Signed-off-by: leo <longshuang@msn.cn>

Author: love-linger

src/ViewModels/BlameCommandPalette.cs

@@ -35,9 +35,8 @@ public string SelectedFile
             set => SetProperty(ref _selectedFile, value);
         }
 
-        public BlameCommandPalette(Launcher launcher, string repo)
+        public BlameCommandPalette(string repo)
         {
-            _launcher = launcher;
             _repo = repo;
             _isLoading = true;
 
@@ -61,27 +60,19 @@ public BlameCommandPalette(Launcher launcher, string repo)
             });
         }
 
-        public override void Cleanup()
-        {
-            _launcher = null;
-            _repo = null;
-            _head = null;
-            _repoFiles.Clear();
-            _filter = null;
-            _visibleFiles.Clear();
-            _selectedFile = null;
-        }
-
         public void ClearFilter()
         {
             Filter = string.Empty;
         }
 
         public void Launch()
         {
+            _repoFiles.Clear();
+            _visibleFiles.Clear();
+            Close();
+
             if (!string.IsNullOrEmpty(_selectedFile))
                 App.ShowWindow(new Blame(_repo, _selectedFile, _head));
-            _launcher.CancelCommandPalette();
         }
 
         private void UpdateVisible()
@@ -117,7 +108,6 @@ private void UpdateVisible()
             }
         }
 
-        private Launcher _launcher = null;
         private string _repo = null;
         private bool _isLoading = false;
         private Models.Commit _head = null;

src/ViewModels/CheckoutCommandPalette.cs

@@ -28,36 +28,24 @@ public string Filter
             }
         }
 
-        public CheckoutCommandPalette(Launcher launcher, Repository repo)
+        public CheckoutCommandPalette(Repository repo)
         {
-            _launcher = launcher;
             _repo = repo;
             UpdateBranches();
         }
 
-        public override void Cleanup()
-        {
-            _launcher = null;
-            _repo = null;
-            _branches.Clear();
-            _selectedBranch = null;
-            _filter = null;
-        }
-
         public void ClearFilter()
         {
             Filter = string.Empty;
         }
 
         public async Task ExecAsync()
         {
-            _launcher.CommandPalette = null;
+            _branches.Clear();
+            Close();
 
             if (_selectedBranch != null)
                 await _repo.CheckoutBranchAsync(_selectedBranch);
-
-            Dispose();
-            GC.Collect();
         }
 
         private void UpdateBranches()
@@ -94,7 +82,6 @@ private void UpdateBranches()
             SelectedBranch = autoSelected;
         }
 
-        private Launcher _launcher;
         private Repository _repo;
         private List<Models.Branch> _branches = [];
         private Models.Branch _selectedBranch = null;

src/ViewModels/CompareCommandPalette.cs

@@ -32,34 +32,25 @@ public string Filter
             }
         }
 
-        public CompareCommandPalette(Launcher launcher, Repository repo, object basedOn)
+        public CompareCommandPalette(Repository repo, object basedOn)
         {
-            _launcher = launcher;
             _repo = repo;
             _basedOn = basedOn ?? repo.CurrentBranch;
             UpdateRefs();
         }
 
-        public override void Cleanup()
-        {
-            _launcher = null;
-            _repo = null;
-            _basedOn = null;
-            _compareTo = null;
-            _refs.Clear();
-            _filter = null;
-        }
-
         public void ClearFilter()
         {
             Filter = string.Empty;
         }
 
         public void Launch()
         {
+            _refs.Clear();
+            Close();
+
             if (_compareTo != null)
                 App.ShowWindow(new Compare(_repo, _basedOn, _compareTo));
-            _launcher?.CancelCommandPalette();
         }
 
         private void UpdateRefs()
@@ -114,7 +105,6 @@ private void UpdateRefs()
             CompareTo = autoSelected;
         }
 
-        private Launcher _launcher;
         private Repository _repo;
         private object _basedOn = null;
         private object _compareTo = null;

src/ViewModels/ExecuteCustomActionCommandPalette.cs

@@ -41,9 +41,8 @@ public string Filter
             }
         }
 
-        public ExecuteCustomActionCommandPalette(Launcher launcher, Repository repo)
+        public ExecuteCustomActionCommandPalette(Repository repo)
         {
-            _launcher = launcher;
             _repo = repo;
 
             var actions = repo.GetCustomActions(Models.CustomActionScope.Repository);
@@ -65,30 +64,19 @@ public ExecuteCustomActionCommandPalette(Launcher launcher, Repository repo)
             }
         }
 
-        public override void Cleanup()
-        {
-            _launcher = null;
-            _repo = null;
-            _actions.Clear();
-            _visibleActions.Clear();
-            _selected = null;
-            _filter = null;
-        }
-
         public void ClearFilter()
         {
             Filter = string.Empty;
         }
 
         public async Task ExecAsync()
         {
-            _launcher.CommandPalette = null;
+            _actions.Clear();
+            _visibleActions.Clear();
+            Close();
 
             if (_selected != null)
                 await _repo.ExecCustomActionAsync(_selected.Action, null);
-
-            Dispose();
-            GC.Collect();
         }
 
         private void UpdateVisibleActions()
@@ -117,7 +105,6 @@ private void UpdateVisibleActions()
             Selected = autoSelected;
         }
 
-        private Launcher _launcher;
         private Repository _repo;
         private List<ExecuteCustomActionCommandPaletteCmd> _actions = [];
         private List<ExecuteCustomActionCommandPaletteCmd> _visibleActions = [];

src/ViewModels/FileHistoryCommandPalette.cs

@@ -35,9 +35,8 @@ public string SelectedFile
             set => SetProperty(ref _selectedFile, value);
         }
 
-        public FileHistoryCommandPalette(Launcher launcher, string repo)
+        public FileHistoryCommandPalette(string repo)
         {
-            _launcher = launcher;
             _repo = repo;
             _isLoading = true;
 
@@ -56,26 +55,19 @@ public FileHistoryCommandPalette(Launcher launcher, string repo)
             });
         }
 
-        public override void Cleanup()
-        {
-            _launcher = null;
-            _repo = null;
-            _repoFiles.Clear();
-            _filter = null;
-            _visibleFiles.Clear();
-            _selectedFile = null;
-        }
-
         public void ClearFilter()
         {
             Filter = string.Empty;
         }
 
         public void Launch()
         {
+            _repoFiles.Clear();
+            _visibleFiles.Clear();
+            Close();
+
             if (!string.IsNullOrEmpty(_selectedFile))
                 App.ShowWindow(new FileHistories(_repo, _selectedFile));
-            _launcher.CancelCommandPalette();
         }
 
         private void UpdateVisible()
@@ -111,7 +103,6 @@ private void UpdateVisible()
             }
         }
 
-        private Launcher _launcher = null;
         private string _repo = null;
         private bool _isLoading = false;
         private List<string> _repoFiles = null;

src/ViewModels/ICommandPalette.cs

@@ -1,17 +1,21 @@
-using System;
-using CommunityToolkit.Mvvm.ComponentModel;
+using CommunityToolkit.Mvvm.ComponentModel;
 
 namespace SourceGit.ViewModels
 {
-    public class ICommandPalette : ObservableObject, IDisposable
+    public class ICommandPalette : ObservableObject
     {
-        public void Dispose()
+        public void Open()
         {
-            Cleanup();
+            var host = App.GetLauncher();
+            if (host != null)
+                host.CommandPalette = this;
         }
 
-        public virtual void Cleanup()
+        public void Close()
         {
+            var host = App.GetLauncher();
+            if (host != null)
+                host.CommandPalette = null;
         }
     }
 }

src/ViewModels/Launcher.cs

@@ -347,23 +347,6 @@ public void OpenRepositoryInTab(RepositoryNode node, LauncherPage page)
                 ActivePage = page;
         }
 
-        public void OpenCommandPalette(ICommandPalette commandPalette)
-        {
-            var old = _commandPalette;
-            CommandPalette = commandPalette;
-            old?.Dispose();
-        }
-
-        public void CancelCommandPalette()
-        {
-            if (_commandPalette != null)
-            {
-                _commandPalette?.Dispose();
-                CommandPalette = null;
-                GC.Collect();
-            }
-        }
-
         public void DispatchNotification(string pageId, string message, bool isError)
         {
             if (!Dispatcher.UIThread.CheckAccess())
@@ -453,7 +436,7 @@ private void PostActivePageChanged()
                 builder.Append(" - ").Append(_activeWorkspace.Name);
 
             Title = builder.ToString();
-            CancelCommandPalette();
+            CommandPalette = null;
         }
 
         private Workspace _activeWorkspace;

src/ViewModels/LauncherPagesCommandPalette.cs

@@ -60,30 +60,22 @@ public LauncherPagesCommandPalette(Launcher launcher)
             UpdateVisible();
         }
 
-        public override void Cleanup()
-        {
-            _launcher = null;
-            _opened.Clear();
-            _visiblePages.Clear();
-            _visibleRepos.Clear();
-            _searchFilter = null;
-            _selectedPage = null;
-            _selectedRepo = null;
-        }
-
         public void ClearFilter()
         {
             SearchFilter = string.Empty;
         }
 
         public void OpenOrSwitchTo()
         {
+            _opened.Clear();
+            _visiblePages.Clear();
+            _visibleRepos.Clear();
+            Close();
+
             if (_selectedPage != null)
                 _launcher.ActivePage = _selectedPage;
             else if (_selectedRepo != null)
                 _launcher.OpenRepositoryInTab(_selectedRepo, null);
-
-            _launcher?.CancelCommandPalette();
         }
 
         private void UpdateVisible()

src/ViewModels/MergeCommandPalette.cs

@@ -27,33 +27,24 @@ public Models.Branch SelectedBranch
             set => SetProperty(ref _selectedBranch, value);
         }
 
-        public MergeCommandPalette(Launcher launcher, Repository repo)
+        public MergeCommandPalette(Repository repo)
         {
-            _launcher = launcher;
             _repo = repo;
             UpdateBranches();
         }
 
-        public override void Cleanup()
-        {
-            _launcher = null;
-            _repo = null;
-            _branches.Clear();
-            _filter = null;
-            _selectedBranch = null;
-        }
-
         public void ClearFilter()
         {
             Filter = string.Empty;
         }
 
         public void Launch()
         {
+            _branches.Clear();
+            Close();
+
             if (_repo.CanCreatePopup() && _selectedBranch != null)
                 _repo.ShowPopup(new Merge(_repo, _selectedBranch, _repo.CurrentBranch.Name, false));
-
-            _launcher?.CancelCommandPalette();
         }
 
         private void UpdateBranches()
@@ -90,7 +81,6 @@ private void UpdateBranches()
             SelectedBranch = autoSelected;
         }
 
-        private Launcher _launcher = null;
         private Repository _repo = null;
         private List<Models.Branch> _branches = new List<Models.Branch>();
         private string _filter = string.Empty;