Skip to content

Misaligned committer column in "Interactive Rebase" window #1037

@ZaLiTHkA

Description

@ZaLiTHkA

note: this came up during the review of PR #1033.

I'm using SourceGit on a MacBook Pro M1 running macOS Sequoia 15.3.1.

in the "Interactive Rebase" window, some commits seem to "push" the committer field over to the right, as seen in the following screenshot:

Image


I discovered that pressing F12 while running from source will open a "Avalonia DevTools", however I'm not familiar with Avalonia, so it's not clear to me what part of the UI is causing this shift.

focussing on commits 9cf1cba9b7 and 639bff9ad8 in the following crop:

Image

I checked the properties for various elements in the row for each commit, and I do see that the DesiredSize of some elements are wildly different...

the "element" column in the following table relates to children of this commit list.

element DesiredSize value row 1 DesiredSize value row 2 notes
Border for the row "grab handle" 14, 14 14, 14
Button for the "commit action selector" 79, 22 79, 22
Grid for the commit message 425, 16 199, 16 massive difference
Grid for the commit details 448, 28 442, 28 small difference
Grid.Avatar for committer avatar 24, 16 24, 16
Grid.TextBlock for committer name 39, 16 39, 16
Grid.Border for commit hash 74, 16 76, 16 small difference
Grid.Border for commit date 148, 16 142, 16 small difference
Grid.Button for "move up" 30, 28 30, 28
Grid.Button for "move down" 30, 28 30, 28

a quick issue search shows that this was discovered and apparently fixed not too long back (see #764), but I don't think this is exactly the same issue... specifically because in this instance, the row that has the committer details shifted right actually has a much shorter message than the row above it.

please do let me know if you need any additional details here. this happens pretty consistently on my machine, happy to help debug this one.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions