fix: Copy in TextDiffView may lost the last line

[gadfly3173]

Reproduce: Press Ctrl + A in TextDiffView and copy

[love-linger]

I've pushed another fix for this issue. See commit 35ee4a4

[gadfly3173]

I think that make the issue worse.

[love-linger]

Very strange.

[love-linger]

The reason of this issue is:

When clamp startIdx and endIdx to [0, lines.Count - 1], the endPosition.Column and startPosition.Column may no longer refer to the row corresponding to endIdx/startIdx

[love-linger]

I can not re-produce the issue shows in your picture.

[gadfly3173]

Run from the code is fine, but the artifacts in CI seems not right.

[love-linger]

Try to use Copy context menu instead of hotkey Ctrl+C which sometimes did not work as expacted.

[gadfly3173]

Try to use Copy context menu instead of hotkey Ctrl+C which sometimes did not work as expacted.

With the CI artifacts, the copy in context menu also not right, that's weird. I'm using Deepin 23 with linux-x64

[love-linger]

I'll download it and try

[love-linger]

Strange. The package.win-x64.zip works as expacted on my PC.

[love-linger]

Please make sure you have downloaded the correct version:

[gadfly3173]

I am sure that I downloaded linux-x64 from https://github.com/sourcegit-scm/sourcegit/actions/runs/13625760977, and run dotnet publish locally will also produce the effect shown in the picture.

[love-linger]

Can you debug this project now?

[gadfly3173]

After I reinstalled the deb/copied the locally packaged files several times, it finally worked, and I had no idea what the problem was.

[gadfly3173]

Currently, copy would append an extra empty line if more than one line is selected.

[love-linger]

Currently, copy would append an extra empty line if more than one line is selected.

It's because that for multiple lines selection, we use StringBuilder.AppendLine which will always add a line-ending character for each line.

[gadfly3173]

I made #1049 to fix this.