Several improvements for the Welcome/Repositories page#1387
Conversation
This is needed since DirectoryInfo.Fullname (and .FullPath) will not "normalize" trailing slashes, so direct equality tests are error-prone. This fixes a bug in ScanRepositories.GetUnmanagedRepositories(), where not all Git repo folders were added. (Also, corrected a variable name from 'founded' to 'found'.)
|
I've manually cherry-picked partial of commits in your PR. Commit 663567e is not picked. I think sort by name in case-sensitive way is more common than case-insensitive and I really do not like it. For example: BTW. Next time, please don't submit so many commits (for different purpose) in a single PR. It's difficult to tell from GitHub which changes correspond to which commit. I can only cherry-pick each commit manually and then review. It's too tiring. |
|
Thank you. I'll use fewer commits and more concise PR branches in the future. But also, you could've asked me and I would have removed the unwanted commit from my PR branch. 😉 However, personally, I find case-sensitive sorting very frustrating, since So at least it should be made a global Preference "Use case-insensitive sorting in all lists" (or similar)! Let's close this PR, I'm working on a new one for optional case-insensitive sorting (including some bug-fixes). 😬 |
|
Follow-up PR for case-insensitive sorting Preference option: #1401 |
DirectoryInfo.Fullname(and.FullPath) will not "normalize" the presence/absence of a trailing slash, making any direct equality tests error-prone.