fix: do NOT reuse CommitDetail across commit#1503
Closed
gadfly3173 wants to merge 1 commit into
Closed
Conversation
CommitDetail reuse may cause CommitDetail being updated by other Repository tab
Collaborator
|
非常奇怪，按理说，CommitDetail存在于Histories中，而不同的Repository，又有自己的Histories对像…… |
Collaborator
|
我需要具体定位一下 |
Contributor
Author
|
我观察到的情况是： A切换到B - SelectedChanges被切换到B的 - DiffContext被设置，但是此时使用的还是A的CommitDetail，内部的_repo是A的 |
love-linger
added a commit
that referenced
this pull request
Jul 3, 2025
…n switching between repositories (#1503) Signed-off-by: leo <longshuang@msn.cn>
Collaborator
|
定位到了，我提交了另一个更改，彻底改了这个问题 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommitDetail reuse may cause CommitDetail being updated by other Repository tab
_sourcegit_20250703182953.mp4