fix: hide file manager and terminal options for invalid repositories#2503
Merged
love-linger merged 1 commit intoJul 1, 2026
Merged
Conversation
love-linger
added a commit
that referenced
this pull request
Jul 1, 2026
- Use `Directory.Exists(_id)` instead of `IsInvalid` since we have alread makes sure it's a repository - For invalid repository node, only show `Delete` entry in context menu Signed-off-by: leo <longshuang@msn.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a repository folder has been deleted, two crash scenarios exist:
On the Welcome page, right-clicking the invalid repository node
(shown with an exclamation mark) and selecting "Open in File Manager"
or "Open in Terminal" crashes with
Win32Exception.Inside an open repository, if the folder is deleted while SourceGit
is running, clicking the external tools button and selecting
"Open in File Manager" or "Open in Terminal" also crashes.
Fix by:
menu when
node.IsInvalidis true, with an early return guard inRepositoryNodeas a defensive safety net.Directory.Existscheck inRepositoryToolbar.OpenWithExternalToolsbefore building the menu.