Skip to content

fix: hide file manager and terminal options for invalid repositories #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
love-linger merged 1 commit into from
Jul 1, 2026
+30 −23
Merged

fix: hide file manager and terminal options for invalid repositories #2503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ViewModels/RepositoryNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,14 @@ public void Move()

public void OpenInFileManager()
{
if (!IsRepository)
if (!IsRepository || IsInvalid)
return;
Native.OS.OpenInFileManager(_id);
}

public void OpenTerminal()
{
if (!IsRepository)
if (!IsRepository || IsInvalid)
return;
Native.OS.OpenTerminal(_id);
}
Expand Down
4 changes: 4 additions & 0 deletions src/Views/RepositoryToolbar.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ private void OpenWithExternalTools(object sender, RoutedEventArgs ev)
if (sender is Button button && DataContext is ViewModels.Repository repo)
{
var fullpath = repo.FullPath;

if (!System.IO.Directory.Exists(fullpath))
return;

var menu = new ContextMenu();
menu.Placement = PlacementMode.BottomEdgeAlignedLeft;

Expand Down
45 changes: 24 additions & 21 deletions src/Views/Welcome.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,29 +174,32 @@ private void OnTreeNodeContextRequested(object sender, ContextRequestedEventArgs
e.Handled = true;
};

var explore = new MenuItem();
explore.Header = App.Text("Repository.Explore");
explore.Icon = this.CreateMenuIcon("Icons.Explore");
explore.Click += (_, e) =>
{
node.OpenInFileManager();
e.Handled = true;
};

var terminal = new MenuItem();
terminal.Header = App.Text("Repository.Terminal");
terminal.Icon = this.CreateMenuIcon("Icons.Terminal");
terminal.Click += (_, e) =>
{
node.OpenTerminal();
e.Handled = true;
};

menu.Items.Add(open);
menu.Items.Add(new MenuItem() { Header = "-" });
menu.Items.Add(explore);
menu.Items.Add(terminal);
menu.Items.Add(new MenuItem() { Header = "-" });

if (!node.IsInvalid)
{
var explore = new MenuItem();
explore.Header = App.Text("Repository.Explore");
explore.Icon = this.CreateMenuIcon("Icons.Explore");
explore.Click += (_, e) =>
{
node.OpenInFileManager();
e.Handled = true;
};

var terminal = new MenuItem();
terminal.Header = App.Text("Repository.Terminal");
terminal.Icon = this.CreateMenuIcon("Icons.Terminal");
terminal.Click += (_, e) =>
{
node.OpenTerminal();
e.Handled = true;
};
menu.Items.Add(explore);
menu.Items.Add(terminal);
menu.Items.Add(new MenuItem() { Header = "-" });
}
}
else
{
Expand Down
Loading