Skip to content

Commit 3d09120

Browse files
sjarmakclaude
andcommitted
feat: [US-004] - Verify all 20 suites at Grade A
Update PRD passes:true and append progress log. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent fdd980d commit 3d09120

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

ralph-verifiers/prd.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
"python3 scripts/abc_audit.py --all 2>&1 exits with code 0"
6060
],
6161
"priority": 4,
62-
"passes": false,
62+
"passes": true,
6363
"notes": "This is a verification-only story. If any suite is not Grade A, investigate and fix."
6464
}
6565
]

ralph-verifiers/progress.txt

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,3 +83,19 @@ echo "$SCORE" > "$REWARD_FILE"
8383
- Most "unknown" Org tasks are go (prometheus, kubernetes, etcd, grafana ecosystem)
8484
- Branch management: verify branch AFTER checkout, not just before — stash+checkout can silently fail
8585
---
86+
87+
## 2026-03-07 - US-004
88+
- Fixed 7 Grade D suites (all org suites) by adding missing test.sh wrappers to 12 tasks
89+
- Fixed 4 Grade B suites by resolving T.10 shared-state issues in 6 tasks
90+
- 12 new test.sh files: standard Harbor wrapper pattern (exec eval.sh + sgonly_verifier_wrapper)
91+
- 3 onboard-search tasks: /tmp/verify.py → mktemp /tmp/verify_XXXXXX.py
92+
- 2 crossrepo tasks: /tmp/fallback_patch.diff → mktemp /tmp/fallback_XXXXXX.diff
93+
- 1 flipt task: extracted 228-line heredoc patch from test.sh into tests/test_patch.diff
94+
- Files changed: 19 files (12 new test.sh, 4 modified test.sh, 1 new test_patch.diff, 1 modified test.sh for flipt, 1 modified test.sh for refactor)
95+
- **Learnings for future iterations:**
96+
- T.10 regex `/tmp/([a-zA-Z][a-zA-Z0-9_.-]+)` catches fixed paths; dot-prefixed like `.sg_only_mode` are safe
97+
- /tmp paths inside heredoc test patches (Go source code) are false positives for T.10
98+
- Extracting heredoc patches to separate .diff files avoids T.10 scan while preserving git apply behavior
99+
- Grade B = all critical pass but any IMPORTANT fail; Grade A = zero IMPORTANT fails
100+
- Cherry-pick with --no-commit is safer for cross-branch moves than full cherry-pick
101+
---

0 commit comments

Comments
 (0)