Skip to content

Commit f20444c

Browse files
sjarmakclaude
andcommitted
fix: repair verifier env for 2 ccb_feature tasks
servo-scrollend-event-feat-001: - Add `clang` to Dockerfile + Dockerfile.sg_only apt install - mozangle build script needs libclang.so.* (shared lib); libclang-dev only provides the static lib and headers — clang package adds the SO vscode-stale-diagnostics-feat-001: - Add libxkbfile-dev + libx11-dev to Dockerfile so native-keymap compiles cleanly during npm install - Replace `npx tsc` with `./node_modules/.bin/tsc` in test.sh (3 sites) to prevent npx auto-installing tsc@2.0.4 instead of the project's tsc Both tasks were classified completed_fail due to environment bugs, not agent difficulty. Agents made code changes; verifier toolchain was broken. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 2624921 commit f20444c

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

benchmarks/ccb_feature/servo-scrollend-event-feat-001/environment/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
1212
autoconf \
1313
pkg-config \
1414
libclang-dev \
15+
clang \
1516
&& rm -rf /var/lib/apt/lists/*
1617

1718
# Create claude user and writable work dirs before clone.

benchmarks/ccb_feature/servo-scrollend-event-feat-001/environment/Dockerfile.sg_only

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
1313
python3 \
1414
curl \
1515
libclang-dev \
16+
clang \
1617
&& rm -rf /var/lib/apt/lists/*
1718

1819
WORKDIR /workspace

benchmarks/ccb_feature/vscode-stale-diagnostics-feat-001/environment/Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
99
build-essential \
1010
python3 \
1111
python3-pip \
12+
libxkbfile-dev \
13+
libx11-dev \
1214
&& rm -rf /var/lib/apt/lists/*
1315

1416
# Create claude user and writable work dirs before clone.

benchmarks/ccb_feature/vscode-stale-diagnostics-feat-001/tests/test.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ TYPE_CHECK_OK=1
8484
# Try the specific tsconfig for typescript-language-features first, then
8585
# fall back to a broader check on modified files only.
8686
if [ -f "extensions/typescript-language-features/tsconfig.json" ]; then
87-
npx tsc --noEmit -p extensions/typescript-language-features/tsconfig.json 2>/logs/verifier/typecheck_errors.txt && TSC_RC=0 || TSC_RC=$?
87+
./node_modules/.bin/tsc --noEmit -p extensions/typescript-language-features/tsconfig.json 2>/logs/verifier/typecheck_errors.txt && TSC_RC=0 || TSC_RC=$?
8888
if [ "$TSC_RC" -ne 0 ]; then
8989
echo "FAIL: TypeScript type-check failed for typescript-language-features"
9090
TYPE_CHECK_OK=0
@@ -93,7 +93,7 @@ fi
9393

9494
# Also check src/ if a tsconfig exists there
9595
if [ -f "src/tsconfig.json" ]; then
96-
npx tsc --noEmit -p src/tsconfig.json 2>>/logs/verifier/typecheck_errors.txt && TSC_RC=0 || TSC_RC=$?
96+
./node_modules/.bin/tsc --noEmit -p src/tsconfig.json 2>>/logs/verifier/typecheck_errors.txt && TSC_RC=0 || TSC_RC=$?
9797
if [ "$TSC_RC" -ne 0 ]; then
9898
echo "FAIL: TypeScript type-check failed for src/"
9999
TYPE_CHECK_OK=0
@@ -117,7 +117,7 @@ $(git diff --cached --name-only -- '*.ts' 2>/dev/null || true)"
117117
echo "Checking $(echo "$MODIFIED_TS" | wc -l) modified .ts files..."
118118
echo "$MODIFIED_TS" | while read -r tsfile; do
119119
if [ -f "$tsfile" ]; then
120-
npx tsc --noEmit --isolatedModules --skipLibCheck "$tsfile" 2>>/logs/verifier/typecheck_errors.txt || {
120+
./node_modules/.bin/tsc --noEmit --isolatedModules --skipLibCheck "$tsfile" 2>>/logs/verifier/typecheck_errors.txt || {
121121
echo "FAIL: Type-check failed for $tsfile"
122122
# Signal failure via a marker file since we're in a subshell
123123
touch /logs/verifier/typecheck_failed

0 commit comments

Comments
 (0)