chore: refurbish CI setup (#90)

Author: unknwon

.github/workflows/go-test.yml

@@ -0,0 +1,56 @@
+name: Go
+on:
+  push:
+    branches: [ main ]
+    paths:
+      - '**.go'
+      - 'go.mod'
+      - '.golangci.yml'
+      - '.github/workflows/go.yml'
+  pull_request:
+    paths:
+      - '**.go'
+      - 'go.mod'
+      - '.golangci.yml'
+      - '.github/workflows/go.yml'
+env:
+  GOPROXY: "https://proxy.golang.org"
+
+jobs:
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+      - name: Run golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          version: latest
+          args: --timeout=30m
+      - name: Check Go module tidiness
+        shell: bash
+        run: |
+          go mod tidy
+          STATUS=$(git status --porcelain go.mod go.sum)
+          if [ ! -z "$STATUS" ]; then
+            echo "Running go mod tidy modified go.mod and/or go.sum"
+            exit 1
+          fi
+
+  test:
+    name: Test
+    strategy:
+      matrix:
+        go-version: [ 1.18.x ]
+        platform: [ ubuntu-latest ]
+    runs-on: ${{ matrix.platform }}
+    steps:
+      - name: Install Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: ${{ matrix.go-version }}
+      - name: Checkout code
+        uses: actions/checkout@v2
+      - name: Run tests with coverage
+        run: go test -v -race ./...

.github/workflows/go.yml

@@ -1,13 +1,28 @@
 name: LSIF
 on:
-  - push
+  push:
+    paths:
+      - '**.go'
+      - 'go.mod'
+      - '.github/workflows/lsif.yml'
+env:
+  GOPROXY: "https://proxy.golang.org"
+
 jobs:
   lsif-go:
+    if: github.repository == 'sourcegraph/docsite'
     runs-on: ubuntu-latest
-    container: sourcegraph/lsif-go
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: Generate LSIF data
-        run: lsif-go
-      - name: Upload LSIF data
-        run: src lsif upload -github-token=${{ secrets.GITHUB_TOKEN }}
+        uses: sourcegraph/lsif-go-action@master
+      - name: Upload LSIF data to sourcegraph.com
+        continue-on-error: true
+        uses: docker://sourcegraph/src-cli:latest
+        with:
+          args: lsif upload -github-token=${{ secrets.GITHUB_TOKEN }}
+      - name: Upload LSIF data to S2
+        continue-on-error: true
+        uses: docker://sourcegraph/src-cli:latest
+        with:
+          args: -endpoint=https://sourcegraph.sourcegraph.com lsif upload -github-token=${{ secrets.GITHUB_TOKEN }}

.github/workflows/lsif.yml

@@ -14,7 +14,7 @@ func init() {
 	)
 
 	handler := func(args []string) error {
-		flagSet.Parse(args)
+		_ = flagSet.Parse(args)
 		site, _, err := siteFromFlags()
 		if err != nil {
 			return err
@@ -25,7 +25,7 @@ func init() {
 		}
 		if len(problems) > 0 {
 			for _, problem := range problems {
-				fmt.Fprintln(os.Stderr, problem)
+				_, _ = fmt.Fprintln(os.Stderr, problem)
 			}
 			return fmt.Errorf("%d problems found", len(problems))
 		}

.travis.yml

@@ -69,7 +69,7 @@ func (c commander) run(flagSet *flag.FlagSet, cmdName string, usage *template.Te
 		}
 	}
 	if !flagSet.Parsed() {
-		flagSet.Parse(args)
+		_ = flagSet.Parse(args)
 	}
 
 	// Print usage if the command is "help".
@@ -82,21 +82,21 @@ func (c commander) run(flagSet *flag.FlagSet, cmdName string, usage *template.Te
 	for _, cmd_ := range c {
 		cmd := cmd_
 		cmd.FlagSet.Usage = func() {
-			fmt.Fprintln(commandLine.Output(), "Usage:")
-			fmt.Fprintln(commandLine.Output())
-			fmt.Fprintf(commandLine.Output(), "  %s [options] %s", cmdName, cmd.FlagSet.Name())
+			_, _ = fmt.Fprintln(commandLine.Output(), "Usage:")
+			_, _ = fmt.Fprintln(commandLine.Output())
+			_, _ = fmt.Fprintf(commandLine.Output(), "  %s [options] %s", cmdName, cmd.FlagSet.Name())
 			if hasFlags(cmd.FlagSet) {
-				fmt.Fprint(commandLine.Output(), " [command options]")
+				_, _ = fmt.Fprint(commandLine.Output(), " [command options]")
 			}
-			fmt.Fprintln(commandLine.Output())
+			_, _ = fmt.Fprintln(commandLine.Output())
 			if cmd.LongDescription != "" {
-				fmt.Fprintln(commandLine.Output())
-				fmt.Fprintln(commandLine.Output(), cmd.LongDescription)
-				fmt.Fprintln(commandLine.Output())
+				_, _ = fmt.Fprintln(commandLine.Output())
+				_, _ = fmt.Fprintln(commandLine.Output(), cmd.LongDescription)
+				_, _ = fmt.Fprintln(commandLine.Output())
 			}
 			if hasFlags(cmd.FlagSet) {
-				fmt.Fprintln(commandLine.Output(), "The command options are:")
-				fmt.Fprintln(commandLine.Output())
+				_, _ = fmt.Fprintln(commandLine.Output(), "The command options are:")
+				_, _ = fmt.Fprintln(commandLine.Output())
 				cmd.FlagSet.PrintDefaults()
 			}
 		}

cmd/docsite/check.go

@@ -13,7 +13,7 @@ func init() {
 	)
 
 	handler := func(args []string) error {
-		flagSet.Parse(args)
+		_ = flagSet.Parse(args)
 		site, _, err := siteFromFlags()
 		if err != nil {
 			return err

cmd/docsite/cmd.go

@@ -10,7 +10,7 @@ func init() {
 	flagSet := flag.NewFlagSet("info", flag.ExitOnError)
 
 	handler := func(args []string) error {
-		flagSet.Parse(args)
+		_ = flagSet.Parse(args)
 		_, conf, err := siteFromFlags()
 		if err != nil {
 			return err

cmd/docsite/fs.go

@@ -16,7 +16,7 @@ func init() {
 	)
 
 	handler := func(args []string) error {
-		flagSet.Parse(args)
+		_ = flagSet.Parse(args)
 		site, _, err := siteFromFlags()
 		if err != nil {
 			return err

cmd/docsite/info.go

@@ -19,7 +19,7 @@ func init() {
 	)
 
 	handler := func(args []string) error {
-		flagSet.Parse(args)
+		_ = flagSet.Parse(args)
 
 		host, port, err := net.SplitHostPort(*httpAddr)
 		if err != nil {