Add support for new/removed binary files.

Add test cases.

Author: dmitshur

diff/diff_test.go

@@ -135,6 +135,21 @@ func TestParseFileDiffHeaders(t *testing.T) {
 				},
 			},
 		},
+		{
+			filename: "sample_file_extended_empty_new_binary.diff",
+			wantDiff: &FileDiff{
+				OrigName: "/dev/null",
+				OrigTime: nil,
+				NewName:  "b/diff/binary-image.png",
+				NewTime:  nil,
+				Extended: []string{
+					"diff --git a/diff/binary-image.png b/diff/binary-image.png",
+					"new file mode 100644",
+					"index 0000000..b51756e",
+					"Binary files /dev/null and b/diff/binary-image.png differ",
+				},
+			},
+		},
 		{
 			filename: "sample_file_extended_empty_deleted.diff",
 			wantDiff: &FileDiff{
@@ -149,6 +164,21 @@ func TestParseFileDiffHeaders(t *testing.T) {
 				},
 			},
 		},
+		{
+			filename: "sample_file_extended_empty_deleted_binary.diff",
+			wantDiff: &FileDiff{
+				OrigName: "a/187/player/random/gopher-0.png",
+				OrigTime: nil,
+				NewName:  "/dev/null",
+				NewTime:  nil,
+				Extended: []string{
+					"diff --git a/187/player/random/gopher-0.png b/187/player/random/gopher-0.png",
+					"deleted file mode 100644",
+					"index aebdfc7..0000000",
+					"Binary files a/187/player/random/gopher-0.png and /dev/null differ",
+				},
+			},
+		},
 		{
 			filename: "sample_file_extended_empty_rename.diff",
 			wantDiff: &FileDiff{
@@ -365,7 +395,9 @@ func TestParseFileDiffAndPrintFileDiff(t *testing.T) {
 		{filename: "sample_file_no_timestamp.diff"},
 		{filename: "sample_file_extended.diff"},
 		{filename: "sample_file_extended_empty_new.diff"},
+		{filename: "sample_file_extended_empty_new_binary.diff"},
 		{filename: "sample_file_extended_empty_deleted.diff"},
+		{filename: "sample_file_extended_empty_deleted_binary.diff"},
 		{filename: "sample_file_extended_empty_rename.diff"},
 		{filename: "sample_file_extended_empty_binary.diff"},
 		{

diff/parse.go

@@ -329,12 +329,16 @@ func (r *FileDiffReader) ReadExtendedHeaders() ([]string, error) {
 // that follow. It updates fd fields from the parsed extended headers.
 func handleEmpty(fd *FileDiff) (wasEmpty bool) {
 	switch {
-	case len(fd.Extended) == 3 && strings.HasPrefix(fd.Extended[1], "new file mode ") && strings.HasPrefix(fd.Extended[0], "diff --git "):
+	case (len(fd.Extended) == 3 || len(fd.Extended) == 4 && strings.HasPrefix(fd.Extended[3], "Binary files ")) &&
+		strings.HasPrefix(fd.Extended[1], "new file mode ") && strings.HasPrefix(fd.Extended[0], "diff --git "):
+
 		names := strings.SplitN(fd.Extended[0][len("diff --git "):], " ", 2)
 		fd.OrigName = "/dev/null"
 		fd.NewName = names[1]
 		return true
-	case len(fd.Extended) == 3 && strings.HasPrefix(fd.Extended[1], "deleted file mode ") && strings.HasPrefix(fd.Extended[0], "diff --git "):
+	case (len(fd.Extended) == 3 || len(fd.Extended) == 4 && strings.HasPrefix(fd.Extended[3], "Binary files ")) &&
+		strings.HasPrefix(fd.Extended[1], "deleted file mode ") && strings.HasPrefix(fd.Extended[0], "diff --git "):
+
 		names := strings.SplitN(fd.Extended[0][len("diff --git "):], " ", 2)
 		fd.OrigName = names[0]
 		fd.NewName = "/dev/null"

diff/testdata/sample_file_extended_empty_deleted_binary.diff

@@ -0,0 +1,4 @@
+diff --git a/187/player/random/gopher-0.png b/187/player/random/gopher-0.png
+deleted file mode 100644
+index aebdfc7..0000000
+Binary files a/187/player/random/gopher-0.png and /dev/null differ

diff/testdata/sample_file_extended_empty_new_binary.diff

@@ -0,0 +1,4 @@
+diff --git a/diff/binary-image.png b/diff/binary-image.png
+new file mode 100644
+index 0000000..b51756e
+Binary files /dev/null and b/diff/binary-image.png differ