[EXPERIMENTAL/MSS] clean sound functions and test effects

Author: TheRedDaemon

src/OpenSHC/Audio/mss/SoundSystem.func.hpp

@@ -22,14 +22,14 @@ namespace Audio {
             meth_0x424700;
 
             MACRO_FUNCTION_RESOLVER(
-                void (SoundSystem::*)(), true, Address::SHC_3BB0A8C1_0x00467810, &SoundSystem::stopMusicPlayback)
+                void (SoundSystem::*)(), false, Address::SHC_3BB0A8C1_0x00467810, &SoundSystem::stopMusicPlayback)
             stopMusicPlayback;
 
             MACRO_FUNCTION_RESOLVER(
                 void (SoundSystem::*)(), false, Address::SHC_3BB0A8C1_0x00467830, &SoundSystem::endSoundStreamsUnk)
             endSoundStreamsUnk;
 
-            MACRO_FUNCTION_RESOLVER(void (SoundSystem::*)(SHC_SoundStreamInt), true, Address::SHC_3BB0A8C1_0x004799A0,
+            MACRO_FUNCTION_RESOLVER(void (SoundSystem::*)(SHC_SoundStreamInt), false, Address::SHC_3BB0A8C1_0x004799A0,
                 &SoundSystem::endSoundStream)
             endSoundStream;
 

src/OpenSHC/Audio/mss/SoundSystem/endSoundStream.cpp

@@ -5,12 +5,10 @@
 
 #include "OpenSHC/OS.func.hpp"
 
-#include "OpenSHC/Globals/DAT_00df3844.hpp"
+#include "OpenSHC/Globals/DAT_SoundEffectsHelperData1.hpp"
 
-// - DAT_00df3844 did not exist before and is therefore wrongly sorted into the status file
-// - "UnkSoundFlagsAndLoopCount" plays not nice with any number-like operation, the more likely thing therefore are
-// either a union, which allows to access the different parts separately, but this would likely compile to WORD
-// operations, or a bitfield, maybe like this:
+// NOTE:
+// "UnkSoundFlagsAndLoopCount" might be a bitfield, maybe like this:
 //      int loopCount : 16;
 //      int reserved : 13;
 //      int unknownFlag1 : 1;
@@ -32,7 +30,7 @@ namespace Audio {
 
             if (sndStreamIndex == enums::SND_STR_MUSIC) {
                 this->streamActiveUnk_0x20[0] = 0;
-                *DAT_00df3844::ptr = 1;
+                DAT_SoundEffectsHelperData1::ptr->field14_0x54 = true;
                 if (this->musicSampleFileHandleUnk_0x174 != -1) {
                     AIL_end_sample(this->musicSampleUnk_0x170);
                     MACRO_CALL(OS_Func::_ucrt_close)(this->musicSampleFileHandleUnk_0x174);
@@ -43,7 +41,7 @@ namespace Audio {
                 this->musicFileHandle_0x178 = -1;
                 this->musicSampleFileHandleUnk_0x174 = -1;
                 this->mbr_0x188 = 1;
-                *DAT_00df3844::ptr = 0;
+                DAT_SoundEffectsHelperData1::ptr->field14_0x54 = false;
                 this->sec_Section1055_0x3274 = 0;
                 return;
             }

src/OpenSHC/Globals/DAT_00df3844.hpp

@@ -26,8 +26,6 @@ namespace OS {
 
     BOOLEnum __cdecl isEqualGUID(GUID* param_1, GUID* param_2);
 
-    int __cdecl __isnan(double _X);
-
     tm* __cdecl _localtime(time_t* _Time);
 
     __time64_t __cdecl __time64(__time64_t* _Time);

src/OpenSHC/OS.hpp

@@ -98109,7 +98109,6 @@ enum {
     // location:
     // type: /byte[1708]
     SHC_3BB0A8C1_0x02490954 = 0x02490954,
-    // type: /undefined4
-    SHC_3BB0A8C1_0x00df3844 = 0x00df3844,
+
 };
 }

src/precomp/addresses-SHC-3BB0A8C1.hpp

@@ -10880,7 +10880,7 @@ SHC_3BB0A8C1_0x00479369 | 0.0% | Pending
 SHC_3BB0A8C1_0x00479400 | 0.0% | Pending
 SHC_3BB0A8C1_0x00479540 | 0.0% | Pending
 SHC_3BB0A8C1_0x00479790 | 0.0% | Pending
-SHC_3BB0A8C1_0x004799A0 | 96.36% | "_close" is seen as unknown offset call by reccmp
+SHC_3BB0A8C1_0x004799A0 | 100.00% | Reimplemented
 SHC_3BB0A8C1_0x00479A60 | 0.0% | Pending
 SHC_3BB0A8C1_0x00479AB0 | 0.0% | Pending
 SHC_3BB0A8C1_0x00479AF0 | 0.0% | Pending
@@ -42943,4 +42943,3 @@ SHC_3BB0A8C1_0x02490916 | 0.0% | Pending
 SHC_3BB0A8C1_0x02490930 | 0.0% | Pending
 SHC_3BB0A8C1_0x02490936 | 0.0% | Pending
 SHC_3BB0A8C1_0x02490954 | 0.0% | Pending
-SHC_3BB0A8C1_0x00df3844 | 0.0% | Pending