Skip to content

Commit 3bbcdca

Browse files
committed
reimplement: SHC_3BB0A8C1_0x00479E60 improve comment
1 parent 3901581 commit 3bbcdca

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

src/OpenSHC/Audio/mss/SoundSystem/setVolumeUnk.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@ namespace Audio {
1414
if (streamIndex == -1) {
1515
this->sampleVolume = volume;
1616
for (int i = 0; i < 31; ++i) {
17-
// TODO: Most structures are either 32 or 1 and 31. We need to unify these.
18-
// Either everything else is of or sample should take in the int value before.
17+
// TODO: A lot of structures of SoundSystem use an 32 element array. sample_0x190 for example
18+
// uses 31 and might be "missing" its first element. The 0 seems to be used for "something" else
19+
// in general. So either we should one day treat all these as "a value and a 31 element array" or
20+
// like a single 32 array.
1921
AIL_set_sample_volume(
2022
this->sample_0x190[i], (this->sampleSndStructVolumePercentage_0x3174[i + 1] * volume) / 100);
2123
}

0 commit comments

Comments
 (0)