Fix default/examples linting with references to relative IDs (#436)

Fixes: sourcemeta/jsonschema#338
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

Author: jviotti

DEPENDENCIES

@@ -1,3 +1,3 @@
 vendorpull https://github.com/sourcemeta/vendorpull dea311b5bfb53b6926a4140267959ae334d3ecf4
-core https://github.com/sourcemeta/core 69fcfff678e0183fa68852c05ed1e2a266a3f1b3
+core https://github.com/sourcemeta/core acfa98a6ab6bbc76f85c84bd7b38c060e558e829
 jsonschema-test-suite https://github.com/json-schema-org/JSON-Schema-Test-Suite bc919bdb266a4949f8a2425f2f540371604d82b4

test/linter/linter_valid_default_test.cc

@@ -309,3 +309,45 @@ TEST(Linter, valid_default_8) {
 
   EXPECT_EQ(schema, expected);
 }
+
+TEST(Linter, valid_default_9) {
+  sourcemeta::core::SchemaTransformer bundle;
+  bundle.add<sourcemeta::blaze::ValidDefault>(
+      sourcemeta::blaze::default_schema_compiler);
+
+  auto schema{sourcemeta::core::parse_json(R"JSON({
+    "$schema": "https://json-schema.org/draft/2020-12/schema",
+    "properties": {
+      "foo": { "default": 1 },
+      "bar": { "$ref": "ref.schema.json" }
+    }
+  })JSON")};
+
+  auto resolver = [](const std::string_view identifier)
+      -> std::optional<sourcemeta::core::JSON> {
+    if (identifier == "ref.schema.json") {
+      return sourcemeta::core::parse_json(R"JSON({
+        "$schema": "https://json-schema.org/draft/2020-12/schema",
+        "$id": "ref.schema.json"
+      })JSON");
+    }
+
+    return sourcemeta::core::schema_official_resolver(identifier);
+  };
+
+  const auto result =
+      bundle.apply(schema, sourcemeta::core::schema_official_walker, resolver,
+                   transformer_callback_error);
+
+  EXPECT_TRUE(result);
+
+  const auto expected{sourcemeta::core::parse_json(R"JSON({
+    "$schema": "https://json-schema.org/draft/2020-12/schema",
+    "properties": {
+      "foo": { "default": 1 },
+      "bar": { "$ref": "ref.schema.json" }
+    }
+  })JSON")};
+
+  EXPECT_EQ(schema, expected);
+}

test/linter/linter_valid_examples_test.cc

@@ -325,7 +325,7 @@ TEST(Linter, valid_examples_8) {
 
 TEST(Linter, valid_examples_9) {
   sourcemeta::core::SchemaTransformer bundle;
-  bundle.add<sourcemeta::blaze::ValidDefault>(
+  bundle.add<sourcemeta::blaze::ValidExamples>(
       sourcemeta::blaze::default_schema_compiler);
 
   auto schema{sourcemeta::core::parse_json(R"JSON({
@@ -348,3 +348,45 @@ TEST(Linter, valid_examples_9) {
 
   EXPECT_EQ(schema, expected);
 }
+
+TEST(Linter, valid_examples_10) {
+  sourcemeta::core::SchemaTransformer bundle;
+  bundle.add<sourcemeta::blaze::ValidExamples>(
+      sourcemeta::blaze::default_schema_compiler);
+
+  auto schema{sourcemeta::core::parse_json(R"JSON({
+    "$schema": "https://json-schema.org/draft/2020-12/schema",
+    "properties": {
+      "foo": { "examples": [ 1 ] },
+      "bar": { "$ref": "ref.schema.json" }
+    }
+  })JSON")};
+
+  auto resolver = [](const std::string_view identifier)
+      -> std::optional<sourcemeta::core::JSON> {
+    if (identifier == "ref.schema.json") {
+      return sourcemeta::core::parse_json(R"JSON({
+        "$schema": "https://json-schema.org/draft/2020-12/schema",
+        "$id": "ref.schema.json"
+      })JSON");
+    }
+
+    return sourcemeta::core::schema_official_resolver(identifier);
+  };
+
+  const auto result =
+      bundle.apply(schema, sourcemeta::core::schema_official_walker, resolver,
+                   transformer_callback_error);
+
+  EXPECT_TRUE(result);
+
+  const auto expected{sourcemeta::core::parse_json(R"JSON({
+    "$schema": "https://json-schema.org/draft/2020-12/schema",
+    "properties": {
+      "foo": { "examples": [ 1 ] },
+      "bar": { "$ref": "ref.schema.json" }
+    }
+  })JSON")};
+
+  EXPECT_EQ(schema, expected);
+}