Remove the SimpleOutput::stacktrace method (#513)

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

Author: jviotti

src/linter/valid_default.cc

@@ -76,7 +76,16 @@ auto ValidDefault::condition(
   }
 
   std::ostringstream message;
-  output.stacktrace(message);
+  for (const auto &entry : output) {
+    message << entry.message << "\n";
+    message << "  at instance location \"";
+    sourcemeta::core::stringify(entry.instance_location, message);
+    message << "\"\n";
+    message << "  at evaluate path \"";
+    sourcemeta::core::stringify(entry.evaluate_path, message);
+    message << "\"\n";
+  }
+
   return {{{"default"}}, std::move(message).str()};
 }
 

src/linter/valid_examples.cc

@@ -79,7 +79,18 @@ auto ValidExamples::condition(
     if (!result) {
       std::ostringstream message;
       message << "Invalid example instance at index " << cursor << "\n";
-      output.stacktrace(message, "  ");
+      for (const auto &entry : output) {
+        message << "  " << entry.message << "\n";
+        message << "  "
+                << "  at instance location \"";
+        sourcemeta::core::stringify(entry.instance_location, message);
+        message << "\"\n";
+        message << "  "
+                << "  at evaluate path \"";
+        sourcemeta::core::stringify(entry.evaluate_path, message);
+        message << "\"\n";
+      }
+
       return {{{"examples", cursor}}, std::move(message).str()};
     }
 

src/output/include/sourcemeta/blaze/output_simple.h

@@ -114,9 +114,6 @@ class SOURCEMETA_BLAZE_OUTPUT_EXPORT SimpleOutput {
     const std::reference_wrapper<const std::string> schema_location;
   };
 
-  auto stacktrace(std::ostream &stream,
-                  const std::string &indentation = "") const -> void;
-
 private:
 // Exporting symbols that depends on the standard C++ library is considered
 // safe.

src/output/output_simple.cc

@@ -103,17 +103,4 @@ auto SimpleOutput::operator()(
        step.keyword_location});
 }
 
-auto SimpleOutput::stacktrace(std::ostream &stream,
-                              const std::string &indentation) const -> void {
-  for (const auto &entry : *this) {
-    stream << indentation << entry.message << "\n";
-    stream << indentation << "  at instance location \"";
-    sourcemeta::core::stringify(entry.instance_location, stream);
-    stream << "\"\n";
-    stream << indentation << "  at evaluate path \"";
-    sourcemeta::core::stringify(entry.evaluate_path, stream);
-    stream << "\"\n";
-  }
-}
-
 } // namespace sourcemeta::blaze

test/output/output_simple_test.cc

@@ -858,93 +858,3 @@ TEST(Output_simple, annotations_failure_1) {
   EXPECT_FALSE(result);
   EXPECT_ANNOTATION_COUNT(output, 0);
 }
-
-TEST(Output_simple, fail_stacktrace) {
-  const sourcemeta::core::JSON schema{sourcemeta::core::parse_json(R"JSON({
-    "$schema": "https://json-schema.org/draft/2019-09/schema",
-    "properties": {
-      "foo": { "type": "object", "unevaluatedProperties": false },
-      "bar": {
-        "additionalProperties": {
-          "if": {
-            "type": "object",
-            "required": [ "$ref" ]
-          }
-        }
-      }
-    }
-  })JSON")};
-
-  const auto schema_template{sourcemeta::blaze::compile(
-      schema, sourcemeta::core::schema_official_walker,
-      sourcemeta::core::schema_official_resolver,
-      sourcemeta::blaze::default_schema_compiler)};
-
-  const sourcemeta::core::JSON instance{sourcemeta::core::parse_json(R"JSON({
-    "foo": { "/baz": 1 },
-    "bar": { "qux": {} }
-  })JSON")};
-
-  sourcemeta::blaze::SimpleOutput output{instance};
-  sourcemeta::blaze::Evaluator evaluator;
-  const auto result{
-      evaluator.validate(schema_template, instance, std::ref(output))};
-  EXPECT_FALSE(result);
-
-  std::ostringstream message;
-  output.stacktrace(message);
-  EXPECT_EQ(
-      message.str(),
-      R"JSON(The object value was not expected to define the property "/baz"
-  at instance location "/foo/~1baz"
-  at evaluate path "/properties/foo/unevaluatedProperties"
-The object value was not expected to define unevaluated properties
-  at instance location "/foo"
-  at evaluate path "/properties/foo/unevaluatedProperties"
-)JSON");
-}
-
-TEST(Output_simple, fail_stacktrace_with_indentation) {
-  const sourcemeta::core::JSON schema{sourcemeta::core::parse_json(R"JSON({
-    "$schema": "https://json-schema.org/draft/2019-09/schema",
-    "properties": {
-      "foo": { "type": "object", "unevaluatedProperties": false },
-      "bar": {
-        "additionalProperties": {
-          "if": {
-            "type": "object",
-            "required": [ "$ref" ]
-          }
-        }
-      }
-    }
-  })JSON")};
-
-  const auto schema_template{sourcemeta::blaze::compile(
-      schema, sourcemeta::core::schema_official_walker,
-      sourcemeta::core::schema_official_resolver,
-      sourcemeta::blaze::default_schema_compiler)};
-
-  const sourcemeta::core::JSON instance{sourcemeta::core::parse_json(R"JSON({
-    "foo": { "/baz": 1 },
-    "bar": { "qux": {} }
-  })JSON")};
-
-  sourcemeta::blaze::SimpleOutput output{instance};
-  sourcemeta::blaze::Evaluator evaluator;
-  const auto result{
-      evaluator.validate(schema_template, instance, std::ref(output))};
-  EXPECT_FALSE(result);
-
-  std::ostringstream message;
-  output.stacktrace(message, "  ");
-  EXPECT_EQ(
-      message.str(),
-      R"JSON(  The object value was not expected to define the property "/baz"
-    at instance location "/foo/~1baz"
-    at evaluate path "/properties/foo/unevaluatedProperties"
-  The object value was not expected to define unevaluated properties
-    at instance location "/foo"
-    at evaluate path "/properties/foo/unevaluatedProperties"
-)JSON");
-}