Skip to content

Add MCP lifecycle tests on Enterprise given a base path#871

Merged
jviotti merged 1 commit intomainfrom
mcp-path
May 4, 2026
Merged

Add MCP lifecycle tests on Enterprise given a base path#871
jviotti merged 1 commit intomainfrom
mcp-path

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented May 4, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 4, 2026

🤖 Augment PR Summary

Summary: Adds an Enterprise E2E suite that validates MCP endpoint behavior when the instance is configured with a /v1/catalog base path.

Changes:

  • Wire a new enterprise/e2e/path suite into CI and into the top-level make docker target for Enterprise runs
  • Add an Enterprise sandbox config (enterprise/e2e/path/one.json) that sets url to http://localhost:8000/v1/catalog
  • Add Hurl tests covering MCP lifecycle, origin/CORS behavior, protocol version handling, and request validation under the base path
  • Reuse the existing E2E harness (test/e2e/common.mk) via a minimal suite Makefile and standard Compose sandbox

Technical Notes: The new tests assert correct routing under /v1/catalog and that requests missing the base path do not match (404).

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 1f0ff1f Previous: 26266b9 Ratio
Add one schema (0 existing) 155 ms 163 ms 0.95
Add one schema (100 existing) 20 ms 22 ms 0.91
Add one schema (1000 existing) 72 ms 74 ms 0.97
Add one schema (10000 existing) 684 ms 815 ms 0.84
Update one schema (1 existing) 14 ms 15 ms 0.93
Update one schema (101 existing) 21 ms 22 ms 0.95
Update one schema (1001 existing) 72 ms 74 ms 0.97
Update one schema (10001 existing) 674 ms 641 ms 1.05
Cached rebuild (1 existing) 4 ms 4 ms 1
Cached rebuild (101 existing) 6 ms 6 ms 1
Cached rebuild (1001 existing) 26 ms 26 ms 1
Cached rebuild (10001 existing) 240 ms 246 ms 0.98
Index 100 schemas 130 ms 132 ms 0.98
Index 1000 schemas 1030 ms 1108 ms 0.93
Index 10000 schemas 14221 ms 13803 ms 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 1f0ff1f Previous: 26266b9 Ratio
Add one schema (0 existing) 151 ms 159 ms 0.95
Add one schema (100 existing) 25 ms 22 ms 1.14
Add one schema (1000 existing) 70 ms 70 ms 1
Add one schema (10000 existing) 588 ms 851 ms 0.69
Update one schema (1 existing) 17 ms 16 ms 1.06
Update one schema (101 existing) 23 ms 22 ms 1.05
Update one schema (1001 existing) 71 ms 71 ms 1
Update one schema (10001 existing) 623 ms 608 ms 1.02
Cached rebuild (1 existing) 5 ms 6 ms 0.83
Cached rebuild (101 existing) 7 ms 7 ms 1
Cached rebuild (1001 existing) 27 ms 27 ms 1
Cached rebuild (10001 existing) 248 ms 256 ms 0.97
Index 100 schemas 111 ms 143 ms 0.78
Index 1000 schemas 1131 ms 1033 ms 1.09
Index 10000 schemas 13005 ms 13418 ms 0.97

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 02ef2bf into main May 4, 2026
5 checks passed
@jviotti jviotti deleted the mcp-path branch May 4, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant