fix: revert hardcoded chef_version, fix pid_one_command arrays, revert protected files

- Revert chef_version to ENV || current

- Fix pid_one_command from YAML arrays to strings (fixes scan error)

- Remove hardcoded CHEF_VERSION from mise.toml

- Revert metadata.rb and CHANGELOG.md to main (protected files)

Author: damacus

kitchen.dokken.yml

@@ -2,7 +2,7 @@
 driver:
   name: dokken
   privileged: true
-  chef_version: 18.9.4
+  chef_version: <%= ENV['CHEF_VERSION'] || 'current' %>
 
 transport: { name: dokken }
 provisioner: { name: dokken }
@@ -11,84 +11,84 @@ platforms:
   - name: almalinux-8
     driver:
       image: dokken/almalinux-8
-      pid_one_command: ["/usr/lib/systemd/systemd"]
+      pid_one_command: /usr/lib/systemd/systemd
 
   - name: almalinux-9
     driver:
       image: dokken/almalinux-9
-      pid_one_command: ["/usr/lib/systemd/systemd"]
+      pid_one_command: /usr/lib/systemd/systemd
 
   - name: almalinux-10
     driver:
       image: dokken/almalinux-10
-      pid_one_command: ["/usr/lib/systemd/systemd"]
+      pid_one_command: /usr/lib/systemd/systemd
 
   - name: amazonlinux-2023
     driver:
       image: dokken/amazonlinux-2023
-      pid_one_command: ["/usr/lib/systemd/systemd"]
+      pid_one_command: /usr/lib/systemd/systemd
 
   - name: centos-stream-9
     driver:
       image: dokken/centos-stream-9
-      pid_one_command: ["/usr/lib/systemd/systemd"]
+      pid_one_command: /usr/lib/systemd/systemd
 
   - name: centos-stream-10
     driver:
       image: dokken/centos-stream-10
-      pid_one_command: ["/usr/lib/systemd/systemd"]
+      pid_one_command: /usr/lib/systemd/systemd
 
   - name: debian-11
     driver:
       image: dokken/debian-11
-      pid_one_command: ["/bin/systemd"]
+      pid_one_command: /bin/systemd
 
   - name: debian-12
     driver:
       image: dokken/debian-12
-      pid_one_command: ["/bin/systemd"]
+      pid_one_command: /bin/systemd
 
   - name: fedora-latest
     driver:
       image: dokken/fedora-latest
-      pid_one_command: ["/usr/lib/systemd/systemd"]
+      pid_one_command: /usr/lib/systemd/systemd
 
   - name: opensuse-leap-15
     driver:
       image: dokken/opensuse-leap-15
-      pid_one_command: ["/usr/lib/systemd/systemd"]
+      pid_one_command: /usr/lib/systemd/systemd
 
   - name: oraclelinux-8
     driver:
       image: dokken/oraclelinux-8
-      pid_one_command: ["/usr/lib/systemd/systemd"]
+      pid_one_command: /usr/lib/systemd/systemd
 
   - name: oraclelinux-9
     driver:
       image: dokken/oraclelinux-9
-      pid_one_command: ["/usr/lib/systemd/systemd"]
+      pid_one_command: /usr/lib/systemd/systemd
 
   - name: rockylinux-8
     driver:
       image: dokken/rockylinux-8
-      pid_one_command: ["/usr/lib/systemd/systemd"]
+      pid_one_command: /usr/lib/systemd/systemd
 
   - name: rockylinux-9
     driver:
       image: dokken/rockylinux-9
-      pid_one_command: ["/usr/lib/systemd/systemd"]
+      pid_one_command: /usr/lib/systemd/systemd
 
   - name: ubuntu-20.04
     driver:
       image: dokken/ubuntu-20.04
-      pid_one_command: ["/bin/systemd"]
+      pid_one_command: /bin/systemd
 
   - name: ubuntu-22.04
     driver:
       image: dokken/ubuntu-22.04
-      pid_one_command: ["/bin/systemd"]
+      pid_one_command: /bin/systemd
 
   - name: ubuntu-24.04
     driver:
       image: dokken/ubuntu-24.04
-      pid_one_command: ["/bin/systemd"]
+      pid_one_command: /bin/systemd

metadata.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 name              'haproxy'
 maintainer        'Sous Chefs'
 maintainer_email  'help@sous-chefs.org'
@@ -10,15 +8,9 @@
 issues_url        'https://github.com/sous-chefs/haproxy/issues'
 chef_version      '>= 16'
 
-supports 'almalinux'
-supports 'amazon'
-supports 'centos'
 supports 'debian'
-supports 'fedora'
-supports 'opensuseleap'
-supports 'oracle'
-supports 'redhat'
-supports 'rocky'
 supports 'ubuntu'
-
+supports 'centos'
+supports 'amazon'
+supports 'opensuseleap'
 depends 'yum-epel'

mise.toml

@@ -1,4 +1,3 @@
 [env]
 _.path = "/opt/chef-workstation/bin"
 KITCHEN_LOCAL_YAML = "kitchen.dokken.yml"
-CHEF_VERSION = "18.8.72"

spec/unit/resources/install_spec.rb

@@ -51,7 +51,7 @@
     platform 'almalinux', '9'
 
     recipe do
-      node.automatic['platform_version'] = '10'
+      node.automatic['platform_version'] = '10.0'
       haproxy_install 'source'
     end
     before(:each) do