feat(transit): serve platform=all ads to specific platforms + admin bulk retag#85
Merged
hc-sousa merged 1 commit intoJun 4, 2026
Conversation
…ulk retag select_ad now treats platform=all campaigns as eligible for any specific client platform (ios/android) for both active and default ads. Adds an AdAdmin bulk action to set selected ads' platform to all (R10, KTD8). Co-authored-by: henrique <henrique@sousadev.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backend half of the transit first-party ads + premium gating plan (
2026-06-04-003, U1).select_adnow treatsplatform='all'campaigns as eligible for a specific client platform (ios/android) for both active and default ads, so iOS clients receive cross-platform inventory (KTD8, R10).AdAdminbulk action "Set platform to all (selected)" so staff can retag campaigns toallfrom the Django admin changelist.Tests
src/transit/tests/test_ads.py—platform=allserved to iOS,platform=webnot served to iOS, defaultallfallback, iOS-targeted served, and the admin bulk action updating N rows.cd src && pytest transit/tests/test_ads.py(5 passed)