Skip to content

Commit 49a7bcd

Browse files
committed
requested changes
1 parent dd42137 commit 49a7bcd

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

src/main/java/ch/njol/skript/lang/parser/DefaultValueData.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public <T> void addDefaultValue(Class<T> type, DefaultExpression<T> value) {
4646
* @return The default value for type, or null if none is set.
4747
*/
4848
public <T> @Nullable DefaultExpression<T> getDefaultValue(Class<T> type) {
49-
Deque<DefaultExpression<?>> stack = defaults.get(type);
49+
Deque<DefaultExpression<?>> stack = defaults.get(type);
5050
if (stack == null || stack.isEmpty())
5151
return null;
5252
//noinspection unchecked
@@ -60,9 +60,12 @@ public <T> void addDefaultValue(Class<T> type, DefaultExpression<T> value) {
6060
* @param type Which class to remove the default value of.
6161
*/
6262
public void removeDefaultValue(Class<?> type) {
63-
Deque<DefaultExpression<?>> stack = defaults.get(type);
64-
if (stack != null && !stack.isEmpty())
63+
Deque<DefaultExpression<?>> stack = defaults.get(type);
64+
if (stack != null && !stack.isEmpty()) {
6565
stack.pop();
66+
} else {
67+
throw new IllegalStateException("No default value for " + type.getName() + " to remove. Imbalanced add/remove?");
68+
}
6669
}
6770

6871
}

src/main/java/ch/njol/skript/test/runner/ExprDefaultNumberValue.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package ch.njol.skript.test.runner;
22

33
import ch.njol.skript.Skript;
4+
import ch.njol.skript.doc.NoDoc;
45
import ch.njol.skript.lang.Expression;
56
import ch.njol.skript.lang.ExpressionType;
67
import ch.njol.skript.lang.SkriptParser.ParseResult;
@@ -9,6 +10,7 @@
910
import org.bukkit.event.Event;
1011
import org.jetbrains.annotations.Nullable;
1112

13+
@NoDoc
1214
public class ExprDefaultNumberValue extends SimpleExpression<Number> {
1315

1416
static {

0 commit comments

Comments
 (0)