requested changes

Author: sovdeeth

src/main/java/ch/njol/skript/effects/EffPotion.java

@@ -108,7 +108,7 @@ protected void execute(Event event) {
 				if (timespan == null)
 					return;
 				if (timespan.isInfinite()) {
-					duration = -1;
+					duration = PotionEffect.INFINITE_DURATION;
 				} else {
 					duration = (int) Math.min(timespan.getAs(Timespan.TimePeriod.TICK), Integer.MAX_VALUE);
 				}

src/main/java/ch/njol/skript/expressions/ExprPotionEffect.java

@@ -67,7 +67,7 @@ protected PotionEffect[] get(final Event e) {
 		if (this.timespan != null) {
 			Timespan timespan = this.timespan.getSingle(e);
 			if (timespan != null) {
-				ticks = timespan.isInfinite() ? -1 : (int) timespan.getAs(Timespan.TimePeriod.TICK);
+				ticks = timespan.isInfinite() ? PotionEffect.INFINITE_DURATION : (int) timespan.getAs(Timespan.TimePeriod.TICK);
 			}
 		}
 		return new PotionEffect[]{new PotionEffect(potionEffectType, ticks, tier, ambient, particles)};

src/main/java/ch/njol/skript/expressions/LitEternity.java

@@ -7,7 +7,7 @@
 import ch.njol.skript.doc.Since;
 import ch.njol.skript.lang.Expression;
 import ch.njol.skript.lang.ExpressionType;
-import ch.njol.skript.lang.SkriptParser;
+import ch.njol.skript.lang.SkriptParser.ParseResult;
 import ch.njol.skript.lang.util.SimpleLiteral;
 import ch.njol.skript.util.Timespan;
 import ch.njol.util.Kleenean;
@@ -29,16 +29,15 @@ public class LitEternity extends SimpleLiteral<Timespan> {
 		Skript.registerExpression(LitEternity.class, Timespan.class, ExpressionType.SIMPLE,
 				"[an] eternity",
 				"forever",
-				"[an] (indefinite|infinite) (duration|timespan)"
-			);
+				"[an] (indefinite|infinite) (duration|timespan)");
 	}
 
 	public LitEternity() {
 		super(new Timespan[]{Timespan.infinite()}, Timespan.class, true);
 	}
 
 	@Override
-	public boolean init(Expression<?>[] exprs, int matchedPattern, Kleenean isDelayed, SkriptParser.ParseResult parseResult) {
+	public boolean init(Expression<?>[] exprs, int matchedPattern, Kleenean isDelayed, ParseResult parseResult) {
 		return true;
 	}
 

src/main/java/ch/njol/skript/util/Timespan.java

@@ -149,11 +149,20 @@ else if (length == 3 && !hasMs || length == 4) // HH:MM:SS[.ms]
 		return new Timespan(totalMillis);
 	}
 
+	/**
+	 * Creates a {@link Timespan} from the given {@link Duration}.
+	 * @param duration The duration to convert to a Timespan.
+	 * @return A new Timespan object representing the duration, based on its milliseconds.
+	 */
 	@Contract("_ -> new")
 	public static @NotNull Timespan fromDuration(@NotNull Duration duration) {
 		return new Timespan(duration.toMillis());
 	}
 
+	/**
+	 * Creates a {@link Timespan} that represents an infinite duration.
+	 * @return A new Timespan object representing an infinite duration.
+	 */
 	@Contract(value = " -> new", pure = true)
 	public static @NotNull Timespan infinite() {
 		return new Timespan(Long.MAX_VALUE);

src/test/skript/tests/syntaxes/expressions/LitEternity.sk

@@ -25,4 +25,3 @@ test "eternity":
 
 	set {_a} to a potion effect of speed for an eternity
 	assert {_a} is infinite with "potion effect was not infinite"
-	assert {_a} is infinite