Skip to content

Commit 56a4dad

Browse files
committed
re-add type in register() and Script#name()
1 parent bb9bd18 commit 56a4dad

5 files changed

Lines changed: 12 additions & 5 deletions

File tree

src/main/java/org/skriptlang/skript/common/expressions/PropExprCustomName.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
public class PropExprCustomName extends PropertyBaseExpression<ExpressionPropertyHandler<?,?>> {
3939

4040
static {
41-
register(PropExprCustomName.class, "(display|nick|chat|custom)[ ]name[s]");
41+
register(PropExprCustomName.class, "(display|nick|chat|custom)[ ]name[s]", "objects");
4242
}
4343

4444
@Override

src/main/java/org/skriptlang/skript/common/expressions/PropExprName.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
public class PropExprName extends PropertyBaseExpression<ExpressionPropertyHandler<?,?>> {
4646

4747
static {
48-
register(PropExprName.class , "name[s]");
48+
register(PropExprName.class , "name[s]", "objects");
4949
}
5050

5151
@Override

src/main/java/org/skriptlang/skript/common/types/ScriptClassInfo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public boolean init(Expression<?> parentExpression, ParserInstance parser) {
9292
@Override
9393
public String convert(final Script script) {
9494
if (useResolvedName)
95-
return script.getConfig().name();
95+
return script.name();
9696
return script.nameAndPath();
9797
}
9898

src/main/java/org/skriptlang/skript/lang/properties/PropertyBaseExpression.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@
3737
*/
3838
public abstract class PropertyBaseExpression<Handler extends ExpressionPropertyHandler<?,?>> extends SimpleExpression<Object> {
3939

40-
protected static void register(Class<? extends PropertyBaseExpression<?>> expressionClass, String property) {
41-
Skript.registerExpression(expressionClass, Object.class, ExpressionType.PROPERTY, PropertyExpression.getPatterns(property, "objects"));
40+
protected static void register(Class<? extends PropertyBaseExpression<?>> expressionClass, String property, String types) {
41+
Skript.registerExpression(expressionClass, Object.class, ExpressionType.PROPERTY, PropertyExpression.getPatterns(property, types));
4242
}
4343

4444
protected Expression<?> expr;

src/main/java/org/skriptlang/skript/lang/script/Script.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,13 @@ public <Value extends ScriptData> Value getData(Class<? extends Value> dataType,
138138
return (Value) scriptData.computeIfAbsent(dataType, clazz -> mapper.get());
139139
}
140140

141+
/**
142+
* @return The name of this script (excluding path and file extensions)
143+
*/
144+
public String name() {
145+
return config.name();
146+
}
147+
141148
/**
142149
* This is added to support the legacy script name syntax.
143150
* Script names used to be printed including their directory but excluding their file extension.

0 commit comments

Comments
 (0)