Skip to content

Commit 6b7f547

Browse files
Fix HTML Documentation Generation (SkriptLang#8341)
Fix Event ID resolution for HTMLGenerator
1 parent 25dd291 commit 6b7f547

1 file changed

Lines changed: 12 additions & 10 deletions

File tree

src/main/java/ch/njol/skript/doc/HTMLGenerator.java

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import org.bukkit.event.block.BlockCanBuildEvent;
1616
import org.jetbrains.annotations.NotNull;
1717
import org.jetbrains.annotations.Nullable;
18+
import org.skriptlang.skript.bukkit.registration.BukkitSyntaxInfos;
1819
import org.skriptlang.skript.lang.entry.EntryData;
1920
import org.skriptlang.skript.lang.entry.EntryValidator;
2021
import org.skriptlang.skript.lang.structure.StructureInfo;
@@ -97,24 +98,24 @@ private static <T> Iterator<SyntaxElementInfo<? extends T>> sortedAnnotatedItera
9798
/**
9899
* Sorts events alphabetically.
99100
*/
100-
private static class EventComparator implements Comparator<SkriptEventInfo<?>> {
101+
private static class EventComparator implements Comparator<BukkitSyntaxInfos.Event<?>> {
101102

102103
public EventComparator() {}
103104

104105
@Override
105-
public int compare(@Nullable SkriptEventInfo<?> o1, @Nullable SkriptEventInfo<?> o2) {
106+
public int compare(@Nullable BukkitSyntaxInfos.Event<?> o1, @Nullable BukkitSyntaxInfos.Event<?> o2) {
106107
// Nullness check
107108
if (o1 == null || o2 == null) {
108109
assert false;
109110
throw new NullPointerException();
110111
}
111112

112-
if (o1.getElementClass().getAnnotation(NoDoc.class) != null)
113+
if (o1.type().getAnnotation(NoDoc.class) != null)
113114
return 1;
114-
else if (o2.getElementClass().getAnnotation(NoDoc.class) != null)
115+
else if (o2.type().getAnnotation(NoDoc.class) != null)
115116
return -1;
116117

117-
return o1.name.compareTo(o2.name);
118+
return o1.name().compareTo(o2.name());
118119
}
119120

120121
}
@@ -311,11 +312,11 @@ else if (!filesInside.getName().matches("(?i)(.*)\\.(html?|js|css|json)")) {
311312
}
312313
}
313314
if (genType.equals("events") || isDocsPage) {
314-
List<SkriptEventInfo<?>> events = new ArrayList<>(Skript.getEvents());
315+
List<BukkitSyntaxInfos.Event<?>> events = new ArrayList<>(Skript.instance().syntaxRegistry().syntaxes(BukkitSyntaxInfos.Event.KEY));
315316
events.sort(eventComparator);
316-
for (SkriptEventInfo<?> info : events) {
317+
for (BukkitSyntaxInfos.Event<?> info : events) {
317318
assert info != null;
318-
if (info.getElementClass().getAnnotation(NoDoc.class) != null)
319+
if (info.type().getAnnotation(NoDoc.class) != null)
319320
continue;
320321
generated.append(generateEvent(descTemp, info, generated.toString()));
321322
}
@@ -584,7 +585,8 @@ private String generateAnnotated(String descTemp, SyntaxElementInfo<?> info, @Nu
584585
return desc;
585586
}
586587

587-
private String generateEvent(String descTemp, SkriptEventInfo<?> info, @Nullable String page) {
588+
private String generateEvent(String descTemp, BukkitSyntaxInfos.Event<?> modernInfo, @Nullable String page) {
589+
SkriptEventInfo<?> info = (SkriptEventInfo<?>) SyntaxElementInfo.fromModern(modernInfo);
588590
Class<?> c = info.getElementClass();
589591
String desc;
590592

@@ -631,7 +633,7 @@ private String generateEvent(String descTemp, SkriptEventInfo<?> info, @Nullable
631633
desc = desc.replace("${element.cancellable}", cancellable ? "Yes" : ""); // if not cancellable the section is hidden
632634

633635
// Documentation ID
634-
desc = desc.replace("${element.id}", DocumentationIdProvider.getId(info));
636+
desc = desc.replace("${element.id}", DocumentationIdProvider.getId(modernInfo));
635637

636638
// Events
637639
Events events = c.getAnnotation(Events.class);

0 commit comments

Comments
 (0)