Cleanup, fully implement ExprName, many docs, some other improvements

- allows stateful property handlers
- removes use of AnyNamed
- removes NameHandler in favor of just using ExpressionPropertyHandler
- Avoid exposing silly cast to users when possible in PropertyBaseExpression
- fix issue with handling DELETE and RESET changers in PropertyBaseExpression
- add support for default toString impl in PropertyBaseExpression

Author: sovdeeth

src/main/java/ch/njol/skript/aliases/ItemType.java

@@ -6,7 +6,6 @@
 import ch.njol.skript.bukkitutil.ItemUtils;
 import ch.njol.skript.lang.Unit;
 import ch.njol.skript.lang.util.common.AnyAmount;
-import ch.njol.skript.lang.util.common.AnyNamed;
 import ch.njol.skript.localization.Adjective;
 import ch.njol.skript.localization.GeneralWords;
 import ch.njol.skript.localization.Language;
@@ -49,8 +48,7 @@
 import java.util.stream.Collectors;
 
 @ContainerType(ItemStack.class)
-public class ItemType implements Unit, Iterable<ItemData>, Container<ItemStack>, YggdrasilExtendedSerializable,
-	AnyNamed, AnyAmount {
+public class ItemType implements Unit, Iterable<ItemData>, Container<ItemStack>, YggdrasilExtendedSerializable, AnyAmount {
 
 	private static final boolean IS_RUNNING_1_21 = Skript.isRunningMinecraft(1, 21);
 
@@ -1611,18 +1609,11 @@ public ItemType getBaseType() {
 		return copy;
 	}
 
-	@Override
 	public @Nullable String name() {
 		ItemMeta meta = this.getItemMeta();
 		return meta.hasDisplayName() ? meta.getDisplayName() : null;
 	}
 
-	@Override
-	public boolean supportsNameChange() {
-		return true;
-	}
-
-	@Override
 	public void setName(String name) {
 		ItemMeta meta = this.getItemMeta();
 		meta.setDisplayName(name);

src/main/java/ch/njol/skript/classes/ClassInfo.java

@@ -13,6 +13,7 @@
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 import org.skriptlang.skript.lang.properties.Property;
+import org.skriptlang.skript.lang.properties.Property.PropertyInfo;
 import org.skriptlang.skript.lang.properties.PropertyHandler;
 
 import java.util.*;
@@ -477,13 +478,13 @@ public String toString(final @Nullable Event event, final boolean debug) {
 	}
 
 
-	private final Map<Property<?>, Property.PropertyInfo<?>> propertyInfos = new HashMap<>();
+	private final Map<Property<?>, PropertyInfo<?>> propertyInfos = new HashMap<>();
 
 	public <Handler extends PropertyHandler<T>> ClassInfo<T> property(Property<? super Handler> property, @NotNull Handler handler) {
 		if (propertyInfos.containsKey(property)) {
 			throw new IllegalStateException("Property " + property.name() + " is already registered for the " + c.getName() + " type.");
 		}
-		propertyInfos.put(property, new Property.PropertyInfo<>(property, handler));
+		propertyInfos.put(property, new PropertyInfo<>(property, handler));
 		Classes.CLASS_INFOS_BY_PROPERTY.computeIfAbsent(property, k -> new ArrayList<>()).add(this);
 		return this;
 	}
@@ -492,12 +493,12 @@ public boolean hasProperty(Property<?> property) {
 		return propertyInfos.containsKey(property);
 	}
 
-	public <Handler extends PropertyHandler<?>> @Nullable Property.PropertyInfo<Handler> getPropertyInfo(Property<Handler> property) {
+	public <Handler extends PropertyHandler<?>> @Nullable PropertyInfo<Handler> getPropertyInfo(Property<Handler> property) {
 		if (!propertyInfos.containsKey(property)) {
 			return null;
 		}
 		//noinspection unchecked
-		return (Property.PropertyInfo<Handler>) propertyInfos.get(property);
+		return (PropertyInfo<Handler>) propertyInfos.get(property);
 	}